From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id A27C9384773E; Tue,  7 May 2024 13:44:04 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A27C9384773E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1715089444;
	bh=LdLsTjuslABti0SHR9eH9KE4eZMfK7DjP2QwcUcTQCY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Gbo3on8NZrfGrA72+39ZiztAP1C72jPUfT9ete38iqhpekGjZEib9ZRtC2iXr20YH
	 XoFbdt1J9EeN/ZoolnnoDncl9eLIJ1VX/ik/qKfeQZ70zWNU+Anif4Xo0I0JIgroKc
	 7Z3X9CIAC375IETFzvbyxhG6MRT8PIBHN4oc3Yu8=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/114674] [aarch64] ldp_fusion fails to merge 2
 strs due to imprecise alignment info
Date: Tue, 07 May 2024 13:44:03 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: missed-optimization, patch
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: acoplan at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-114674-4-cid9KlyYTx@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-114674-4@http.gcc.gnu.org/bugzilla/>
References: <bug-114674-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114674

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alex Coplan <acoplan@gcc.gnu.org>:

https://gcc.gnu.org/g:74690ff96b263b8609639b7fbc5d6afd3f19cb98

commit r15-282-g74690ff96b263b8609639b7fbc5d6afd3f19cb98
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Wed Apr 10 16:30:36 2024 +0100

    aarch64: Preserve mem info on change of base for ldp/stp [PR114674]

    The ldp/stp fusion pass can change the base of an access so that the two
    accesses end up using a common base register.  So far we have been using
    adjust_address_nv to do this, but this means that we don't preserve
    other properties of the mem we're replacing.  It seems better to use
    replace_equiv_address_nv, as this will preserve e.g. the MEM_ALIGN of t=
he
    mem whose address we're changing.

    The PR shows that by adjusting the other mem we lose alignment
    information about the original access and therefore end up rejecting an
    otherwise viable pair when --param=3Daarch64-stp-policy=3Daligned is pa=
ssed.
    This patch fixes that by using replace_equiv_address_nv instead.

    Notably this is the same approach as taken by
    aarch64_check_consecutive_mems when a change of base is required, so
    this at least makes things more consistent between the ldp fusion pass
    and the peepholes.

    gcc/ChangeLog:

            PR target/114674
            * config/aarch64/aarch64-ldp-fusion.cc (ldp_bb_info::fuse_pair):
            Use replace_equiv_address_nv on a change of base instead of
            adjust_address_nv on the other access.

    gcc/testsuite/ChangeLog:

            PR target/114674
            * gcc.target/aarch64/pr114674.c: New test.=