public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dizhao at os dot amperecomputing.com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/114674] New: [aarch64] ldp_fusion fails to merge 2 strs due to imprecise alignment info
Date: Wed, 10 Apr 2024 07:41:23 +0000	[thread overview]
Message-ID: <bug-114674-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114674

            Bug ID: 114674
           Summary: [aarch64] ldp_fusion fails to merge 2 strs due to
                    imprecise alignment info
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dizhao at os dot amperecomputing.com
  Target Milestone: ---

For the case below:

        typedef struct {
                unsigned int f1;
                unsigned int f2;
        } test_struct;

        static test_struct ts = {
                123, 456
        };

        void foo(void)
        {
                ts.f2 = 36969 * (ts.f2 & 65535) + (ts.f1 >> 16);
                ts.f1 = 18000 * (ts.f2 & 65535) + (ts.f2 >> 16);
        }

When compiled with "-O3 --param=aarch64-stp-policy=aligned", gcc failed to fuse
the memory access instructions into stp/ldp, the dump file 312r.ldp_fusion1
says "ldp/stp policy says no". However, the accessing to ts.f1 is aligned to 64
bit:

(insn 26 23 33 2 (set (mem/c:SI (lo_sum:DI (reg/f:DI 113)
                (symbol_ref:DI ("*.LANCHOR0") [flags 0x182])) [1 ts.f1+0 S4
A64])
...

So it looks like the 2 str instructions should be fused with
aarch64-stp-policy=aligned.

After debugged this a bit, it seems the problem is ldp_bb_info::fuse_pair
changed the alignment info when calling adjust_address_nv, to rewrite the base
of ts.f1.

             reply	other threads:[~2024-04-10  7:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10  7:41 dizhao at os dot amperecomputing.com [this message]
2024-04-10  7:43 ` [Bug rtl-optimization/114674] " dizhao at os dot amperecomputing.com
2024-04-10  8:34 ` acoplan at gcc dot gnu.org
2024-04-10 13:27 ` acoplan at gcc dot gnu.org
2024-04-10 14:00 ` acoplan at gcc dot gnu.org
2024-04-11  6:40 ` dizhao at os dot amperecomputing.com
2024-05-07 13:44 ` cvs-commit at gcc dot gnu.org
2024-05-07 13:46 ` acoplan at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114674-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).