From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 8C76E3858410; Mon, 15 Apr 2024 15:46:38 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8C76E3858410
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1713195998;
	bh=dN8Eak0MxrRDD3fqRpZFknxvYMU5K5FCmo8yq7LkWWI=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=o8PuAnvoufViiDGjD9sM58bP3FAWxFBeI5YSlafQ5dlORTBibZAkb+glEJ3RNF5T1
	 /a2H/9i7K7JeQCcCM1E97VufMhJTFkMM7W5dlw1jGbRgF6aivHEZtaThVe2Ftv5tLr
	 a2+K6aS9NYSfkprRwBuSt1X05PJ8mXiOVSk81WkU=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgcc/114689] [14 Regression]
 libgcc/config/m68k/fpgnulib.c:305: Suspicious coding ?
Date: Mon, 15 Apr 2024 15:46:37 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libgcc
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-114689-4-TdN6eS3mqW@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-114689-4@http.gcc.gnu.org/bugzilla/>
References: <bug-114689-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114689

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:f8409c3109d2970a1fd63ac1a61601138b7ae46f

commit r14-9976-gf8409c3109d2970a1fd63ac1a61601138b7ae46f
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Apr 15 17:46:03 2024 +0200

    m68k: Quiet up cppcheck warning [PR114689]

    cppcheck apparently warns on the | !!sticky part of the expression and
    using | (!!sticky) quiets it up (it is correct as is).
    The following patch adds the ()s, and also adds them around mant >> 1 j=
ust
    in case it makes it clearer to all readers that the expression is parsed
    that way already.

    2024-04-15  Jakub Jelinek  <jakub@redhat.com>

            PR libgcc/114689
            * config/m68k/fpgnulib.c (__truncdfsf2): Add parentheses around
            !!sticky bitwise or operand to quiet up cppcheck.  Add parenthe=
ses
            around mant >> 1 bitwise or operand.=