* [Bug c++/114691] [11/12/13/14 Regression] Bogus ignoring loop annotation warning
2024-04-11 10:08 [Bug c++/114691] New: [11/12/13/14 Regression] Bogus ignoring loop annotation warning jakub at gcc dot gnu.org
@ 2024-04-11 10:09 ` jakub at gcc dot gnu.org
2024-04-11 10:11 ` jakub at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-04-11 10:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114691
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Priority|P3 |P2
Ever confirmed|0 |1
Last reconfirmed| |2024-04-11
Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org
Target Milestone|--- |11.5
--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114409#c11
contains the fix which has been posted to gcc-patches but not reviewed yet.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug c++/114691] [11/12/13/14 Regression] Bogus ignoring loop annotation warning
2024-04-11 10:08 [Bug c++/114691] New: [11/12/13/14 Regression] Bogus ignoring loop annotation warning jakub at gcc dot gnu.org
2024-04-11 10:09 ` [Bug c++/114691] " jakub at gcc dot gnu.org
@ 2024-04-11 10:11 ` jakub at gcc dot gnu.org
2024-04-12 18:55 ` cvs-commit at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-04-11 10:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114691
Bug 114691 depends on bug 114409, which changed state.
Bug 114409 Summary: [14 Regression] ICE after adding novector pragmas (internal compiler error: in tsubst_expr, at cp/pt.cc:21794) since r14-4229-g9c62af101e11e1cce573c2b3d2e18b403412dbc8
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114409
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug c++/114691] [11/12/13/14 Regression] Bogus ignoring loop annotation warning
2024-04-11 10:08 [Bug c++/114691] New: [11/12/13/14 Regression] Bogus ignoring loop annotation warning jakub at gcc dot gnu.org
2024-04-11 10:09 ` [Bug c++/114691] " jakub at gcc dot gnu.org
2024-04-11 10:11 ` jakub at gcc dot gnu.org
@ 2024-04-12 18:55 ` cvs-commit at gcc dot gnu.org
2024-04-12 18:55 ` [Bug c++/114691] [11/12/13 " jakub at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-04-12 18:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114691
--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:91146346f57cc54dfeb2669347edd0eb3d13af7f
commit r14-9944-g91146346f57cc54dfeb2669347edd0eb3d13af7f
Author: Jakub Jelinek <jakub@redhat.com>
Date: Fri Apr 12 20:53:10 2024 +0200
c++: Fix bogus warnings about ignored annotations [PR114691]
The middle-end warns about the ANNOTATE_EXPR added for while/for loops
if they declare a var inside of the loop condition.
This is because the assumption is that ANNOTATE_EXPR argument is used
immediately in a COND_EXPR (later GIMPLE_COND), but simplify_loop_decl_cond
wraps the ANNOTATE_EXPR inside of a TRUTH_NOT_EXPR, so it no longer
holds.
The following patch fixes that by adding the TRUTH_NOT_EXPR inside of the
ANNOTATE_EXPR argument if any.
2024-04-12 Jakub Jelinek <jakub@redhat.com>
PR c++/114691
* semantics.cc (simplify_loop_decl_cond): Use cp_build_unary_op
with
TRUTH_NOT_EXPR on ANNOTATE_EXPR argument (if any) rather than
ANNOTATE_EXPR itself.
* g++.dg/ext/pr114691.C: New test.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug c++/114691] [11/12/13 Regression] Bogus ignoring loop annotation warning
2024-04-11 10:08 [Bug c++/114691] New: [11/12/13/14 Regression] Bogus ignoring loop annotation warning jakub at gcc dot gnu.org
` (2 preceding siblings ...)
2024-04-12 18:55 ` cvs-commit at gcc dot gnu.org
@ 2024-04-12 18:55 ` jakub at gcc dot gnu.org
2024-04-21 4:09 ` cvs-commit at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-04-12 18:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114691
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[11/12/13/14 Regression] |[11/12/13 Regression] Bogus
|Bogus ignoring loop |ignoring loop annotation
|annotation warning |warning
--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug c++/114691] [11/12/13 Regression] Bogus ignoring loop annotation warning
2024-04-11 10:08 [Bug c++/114691] New: [11/12/13/14 Regression] Bogus ignoring loop annotation warning jakub at gcc dot gnu.org
` (3 preceding siblings ...)
2024-04-12 18:55 ` [Bug c++/114691] [11/12/13 " jakub at gcc dot gnu.org
@ 2024-04-21 4:09 ` cvs-commit at gcc dot gnu.org
2024-04-23 6:44 ` [Bug c++/114691] [11/12 " jakub at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-04-21 4:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114691
--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:ed7be7ba6f125cfda7ad07263213cbe02b7e7ced
commit r13-8632-ged7be7ba6f125cfda7ad07263213cbe02b7e7ced
Author: Jakub Jelinek <jakub@redhat.com>
Date: Fri Apr 12 20:53:10 2024 +0200
c++: Fix bogus warnings about ignored annotations [PR114691]
The middle-end warns about the ANNOTATE_EXPR added for while/for loops
if they declare a var inside of the loop condition.
This is because the assumption is that ANNOTATE_EXPR argument is used
immediately in a COND_EXPR (later GIMPLE_COND), but simplify_loop_decl_cond
wraps the ANNOTATE_EXPR inside of a TRUTH_NOT_EXPR, so it no longer
holds.
The following patch fixes that by adding the TRUTH_NOT_EXPR inside of the
ANNOTATE_EXPR argument if any.
2024-04-12 Jakub Jelinek <jakub@redhat.com>
PR c++/114691
* semantics.cc (simplify_loop_decl_cond): Use cp_build_unary_op
with
TRUTH_NOT_EXPR on ANNOTATE_EXPR argument (if any) rather than
ANNOTATE_EXPR itself.
* g++.dg/ext/pr114691.C: New test.
(cherry picked from commit 91146346f57cc54dfeb2669347edd0eb3d13af7f)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug c++/114691] [11/12 Regression] Bogus ignoring loop annotation warning
2024-04-11 10:08 [Bug c++/114691] New: [11/12/13/14 Regression] Bogus ignoring loop annotation warning jakub at gcc dot gnu.org
` (4 preceding siblings ...)
2024-04-21 4:09 ` cvs-commit at gcc dot gnu.org
@ 2024-04-23 6:44 ` jakub at gcc dot gnu.org
2024-06-11 10:38 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-04-23 6:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114691
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[11/12/13 Regression] Bogus |[11/12 Regression] Bogus
|ignoring loop annotation |ignoring loop annotation
|warning |warning
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 13.3 too.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug c++/114691] [11/12 Regression] Bogus ignoring loop annotation warning
2024-04-11 10:08 [Bug c++/114691] New: [11/12/13/14 Regression] Bogus ignoring loop annotation warning jakub at gcc dot gnu.org
` (5 preceding siblings ...)
2024-04-23 6:44 ` [Bug c++/114691] [11/12 " jakub at gcc dot gnu.org
@ 2024-06-11 10:38 ` cvs-commit at gcc dot gnu.org
2024-06-11 10:53 ` [Bug c++/114691] [11 " jakub at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-06-11 10:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114691
--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:e9b960edb01449786a29a8d196c476bfefc4f243
commit r12-10523-ge9b960edb01449786a29a8d196c476bfefc4f243
Author: Jakub Jelinek <jakub@redhat.com>
Date: Fri Apr 12 20:53:10 2024 +0200
c++: Fix bogus warnings about ignored annotations [PR114691]
The middle-end warns about the ANNOTATE_EXPR added for while/for loops
if they declare a var inside of the loop condition.
This is because the assumption is that ANNOTATE_EXPR argument is used
immediately in a COND_EXPR (later GIMPLE_COND), but simplify_loop_decl_cond
wraps the ANNOTATE_EXPR inside of a TRUTH_NOT_EXPR, so it no longer
holds.
The following patch fixes that by adding the TRUTH_NOT_EXPR inside of the
ANNOTATE_EXPR argument if any.
2024-04-12 Jakub Jelinek <jakub@redhat.com>
PR c++/114691
* semantics.cc (simplify_loop_decl_cond): Use cp_build_unary_op
with
TRUTH_NOT_EXPR on ANNOTATE_EXPR argument (if any) rather than
ANNOTATE_EXPR itself.
* g++.dg/ext/pr114691.C: New test.
(cherry picked from commit 91146346f57cc54dfeb2669347edd0eb3d13af7f)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug c++/114691] [11 Regression] Bogus ignoring loop annotation warning
2024-04-11 10:08 [Bug c++/114691] New: [11/12/13/14 Regression] Bogus ignoring loop annotation warning jakub at gcc dot gnu.org
` (6 preceding siblings ...)
2024-06-11 10:38 ` cvs-commit at gcc dot gnu.org
@ 2024-06-11 10:53 ` jakub at gcc dot gnu.org
2024-06-20 13:23 ` cvs-commit at gcc dot gnu.org
2024-06-20 13:43 ` jakub at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-06-11 10:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114691
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[11/12 Regression] Bogus |[11 Regression] Bogus
|ignoring loop annotation |ignoring loop annotation
|warning |warning
--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Should be fixed for 12.4+ too.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug c++/114691] [11 Regression] Bogus ignoring loop annotation warning
2024-04-11 10:08 [Bug c++/114691] New: [11/12/13/14 Regression] Bogus ignoring loop annotation warning jakub at gcc dot gnu.org
` (7 preceding siblings ...)
2024-06-11 10:53 ` [Bug c++/114691] [11 " jakub at gcc dot gnu.org
@ 2024-06-20 13:23 ` cvs-commit at gcc dot gnu.org
2024-06-20 13:43 ` jakub at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-06-20 13:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114691
--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:6ec50f5b9a8842f92d65dbd8fcc546f0f6902585
commit r11-11505-g6ec50f5b9a8842f92d65dbd8fcc546f0f6902585
Author: Jakub Jelinek <jakub@redhat.com>
Date: Fri Apr 12 20:53:10 2024 +0200
c++: Fix bogus warnings about ignored annotations [PR114691]
The middle-end warns about the ANNOTATE_EXPR added for while/for loops
if they declare a var inside of the loop condition.
This is because the assumption is that ANNOTATE_EXPR argument is used
immediately in a COND_EXPR (later GIMPLE_COND), but simplify_loop_decl_cond
wraps the ANNOTATE_EXPR inside of a TRUTH_NOT_EXPR, so it no longer
holds.
The following patch fixes that by adding the TRUTH_NOT_EXPR inside of the
ANNOTATE_EXPR argument if any.
2024-04-12 Jakub Jelinek <jakub@redhat.com>
PR c++/114691
* semantics.c (simplify_loop_decl_cond): Use cp_build_unary_op with
TRUTH_NOT_EXPR on ANNOTATE_EXPR argument (if any) rather than
ANNOTATE_EXPR itself.
* g++.dg/ext/pr114691.C: New test.
(cherry picked from commit 91146346f57cc54dfeb2669347edd0eb3d13af7f)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug c++/114691] [11 Regression] Bogus ignoring loop annotation warning
2024-04-11 10:08 [Bug c++/114691] New: [11/12/13/14 Regression] Bogus ignoring loop annotation warning jakub at gcc dot gnu.org
` (8 preceding siblings ...)
2024-06-20 13:23 ` cvs-commit at gcc dot gnu.org
@ 2024-06-20 13:43 ` jakub at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-06-20 13:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114691
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 11.5 as well.
^ permalink raw reply [flat|nested] 11+ messages in thread