public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "lin1.hu at intel dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/114700] Front-end optimization generates wrong code with -fsanitize=undefined
Date: Fri, 12 Apr 2024 07:12:52 +0000	[thread overview]
Message-ID: <bug-114700-4-sidnzhgeBV@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114700-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114700

--- Comment #12 from Hu Lin <lin1.hu at intel dot com> ---
(In reply to Hu Lin from comment #11)
> (In reply to Richard Biener from comment #9)
> > That that GCC doesn't promise that -ftrapv preserves all overflows and
> > traps, it merely guarantees that all overflows that actually happen trap. 
> > So GCC is fine to contract some expressions where the overall number of
> > overflows can only
> > decrease.
> > 
> > That's not a bug with -ftrapv.
> > 
> > It is considered a bug with -fsanitize=undefined though.
> 
> I think it doesn't mean that's not a bug with -ftrapv, it should preserve
> all overflow traps. Because it doesn't work, we use -fsanitize=undefined
> instead of it.
> 
> refer: Gcc's trapv is known not always to work correctly.
> 
> The current behavior is correct for -fsanitize=undefined, because the
> integer signed overflow is well-defined, so GCC can eliminate some
> variables. I just think GCC can optimize `z = c  - y  - c + a  + y - b` to
> `z = a - b`. But it doesn't mean is a bug for -fsanitize=undefined.

I was wrong about signed overflow, it's undefined behavior in c++20
(https://en.cppreference.com/w/cpp/language/ub). If I'm not mistaken about the
source, it's a bug.

  parent reply	other threads:[~2024-04-12  7:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12  2:22 [Bug c/114700] New: Front-end optimization generates wrong code with -ftrapv lin1.hu at intel dot com
2024-04-12  2:34 ` [Bug middle-end/114700] " pinskia at gcc dot gnu.org
2024-04-12  2:47 ` lin1.hu at intel dot com
2024-04-12  2:47 ` lin1.hu at intel dot com
2024-04-12  3:21 ` pinskia at gcc dot gnu.org
2024-04-12  3:26 ` pinskia at gcc dot gnu.org
2024-04-12  3:35 ` pinskia at gcc dot gnu.org
2024-04-12  3:53 ` lin1.hu at intel dot com
2024-04-12  3:56 ` lin1.hu at intel dot com
2024-04-12  5:56 ` rguenth at gcc dot gnu.org
2024-04-12  6:33 ` [Bug middle-end/114700] Front-end optimization generates wrong code with -fsanitize=undefined xry111 at gcc dot gnu.org
2024-04-12  6:44 ` lin1.hu at intel dot com
2024-04-12  7:12 ` lin1.hu at intel dot com [this message]
2024-04-12  7:14 ` xry111 at gcc dot gnu.org
2024-04-12  8:51 ` lin1.hu at intel dot com
2024-04-12 10:15 ` [Bug middle-end/114700] middle-end " jakub at gcc dot gnu.org
2024-04-12 10:25 ` jakub at gcc dot gnu.org
2024-04-15  3:43 ` [Bug middle-end/114700] middle-end optimization generates causes -fsanitize=undefined not to happen in some cases lin1.hu at intel dot com
2024-04-15  6:49 ` jakub at gcc dot gnu.org
2024-04-15  7:44 ` lin1.hu at intel dot com
2024-04-17  1:50 ` lin1.hu at intel dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114700-4-sidnzhgeBV@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).