public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/114753] from_chars aborts with -m32 -ftrapv when passed -9223372036854775808 Date: Wed, 17 Apr 2024 11:30:05 +0000 [thread overview] Message-ID: <bug-114753-4-lOQegkIwlC@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-114753-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114753 --- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> --- I wouldn't call it a hack, I'd say it is the right fix. Though, we have tons of those in internal-fn.cc ops.code = MULT_EXPR; ops.code = MULT_EXPR; ops.code = MULT_EXPR; ops.code = MULT_EXPR; ops.code = MULT_EXPR; ops.code = WIDEN_MULT_EXPR; ops.code = MULT_HIGHPART_EXPR; ops.code = MULT_EXPR; ops.code = WIDEN_MULT_EXPR; ops.code = MULT_EXPR; ops.code = MULT_EXPR; ops.code = PLUS_EXPR; ops.code = TRUNC_DIV_EXPR; ops.code = TRUNC_MOD_EXPR; plus some which reuse earlier set ops.code plus some which use just some variable as ops.code. Sure, I think WIDEN_MULT_EXPR/MULT_HIGHPART_EXPR and the div/mod neither probably consider flag_trapv, but MULT_EXPR/PLUS_EXPR does (though, perhaps the PLUS_EXPR is for vectors only). So, the question is where to put that. To cover everything, bet best would be to put it into expand_mul_overflow and expand_arith_overflow and expand_vector_ubsan_overflow.
next prev parent reply other threads:[~2024-04-17 11:30 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-17 10:30 [Bug c++/114753] New: " gnu.ojxq8 at dralias dot com 2024-04-17 10:45 ` [Bug c++/114753] " redi at gcc dot gnu.org 2024-04-17 10:49 ` redi at gcc dot gnu.org 2024-04-17 10:56 ` [Bug middle-end/114753] " rguenth at gcc dot gnu.org 2024-04-17 11:00 ` rguenth at gcc dot gnu.org 2024-04-17 11:30 ` jakub at gcc dot gnu.org [this message] 2024-04-17 12:00 ` jakub at gcc dot gnu.org 2024-04-18 7:45 ` cvs-commit at gcc dot gnu.org 2024-04-18 7:51 ` jakub at gcc dot gnu.org 2024-04-19 16:16 ` cvs-commit at gcc dot gnu.org 2024-04-21 4:09 ` cvs-commit at gcc dot gnu.org 2024-04-23 6:43 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114753-4-lOQegkIwlC@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).