public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/114768] Volatile reads can be optimized away Date: Thu, 18 Apr 2024 13:21:55 +0000 [thread overview] Message-ID: <bug-114768-4-7WW0o1lt8Z@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-114768-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114768 --- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> --- --- gcc/rtlanal.cc.jj 2024-02-24 12:45:28.674249100 +0100 +++ gcc/rtlanal.cc 2024-04-18 15:09:55.199499083 +0200 @@ -1637,12 +1637,15 @@ set_noop_p (const_rtx set) return true; if (MEM_P (dst) && MEM_P (src)) - return rtx_equal_p (dst, src) && !side_effects_p (dst); + return (rtx_equal_p (dst, src) + && !side_effects_p (dst) + && !side_effects_p (src)); if (GET_CODE (dst) == ZERO_EXTRACT) - return rtx_equal_p (XEXP (dst, 0), src) - && !BITS_BIG_ENDIAN && XEXP (dst, 2) == const0_rtx - && !side_effects_p (src); + return (rtx_equal_p (XEXP (dst, 0), src) + && !BITS_BIG_ENDIAN && XEXP (dst, 2) == const0_rtx + && !side_effects_p (src) + && !side_effects_p (XEXP (dst, 0))); if (GET_CODE (dst) == STRICT_LOW_PART) dst = XEXP (dst, 0); should fix this.
next prev parent reply other threads:[~2024-04-18 13:21 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-18 13:19 [Bug rtl-optimization/114768] New: " bouanto at zoho dot com 2024-04-18 13:21 ` [Bug rtl-optimization/114768] " rguenth at gcc dot gnu.org 2024-04-18 13:21 ` jakub at gcc dot gnu.org [this message] 2024-04-18 13:23 ` rguenth at gcc dot gnu.org 2024-04-18 13:46 ` jakub at gcc dot gnu.org 2024-04-18 13:53 ` segher at gcc dot gnu.org 2024-04-18 13:57 ` segher at gcc dot gnu.org 2024-04-19 6:48 ` cvs-commit at gcc dot gnu.org 2024-04-19 6:49 ` jakub at gcc dot gnu.org 2024-04-19 10:38 ` cvs-commit at gcc dot gnu.org 2024-04-21 4:09 ` cvs-commit at gcc dot gnu.org 2024-04-23 6:43 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114768-4-7WW0o1lt8Z@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).