From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 8FEB73858D28; Sun, 21 Apr 2024 05:47:11 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FEB73858D28
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1713678431;
	bh=xx+y2cH/BVsGmuMFF2yFJcT3cGtRISRHAnx5k8yJs+8=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=nI9mWQgL6DTyVgLFy4NiGZHMHdLKT+5Onrkr2EDaiv1jWfC2rph5UfL78ZsLEsyM6
	 miRdFuvYhXXDLBcsjiBRe/ddAjWPWswZ4UADv6QEuPbi01ctexR9flNG9huL7FdHwY
	 gBXiVBF5BZCNy9clHp9OaeDI3Ev8DxSOw2h+B0Vg=
From: "urs at akk dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/114791] analyzer: file-leak not detected
Date: Sun, 21 Apr 2024 05:47:11 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: analyzer
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: urs at akk dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: dmalcolm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-114791-4-NEnkiOLPXV@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-114791-4@http.gcc.gnu.org/bugzilla/>
References: <bug-114791-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114791

--- Comment #3 from Urs Jan=C3=9Fen <urs at akk dot org> ---
Comment on attachment 57998
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=3D57998
minimal test case

>#include <sys/types.h>
>#include <sys/stat.h>
>#include <unistd.h>
>#include <stdio.h>
>
>int main(void);
>
>int main(void) {
>    FILE *fp =3D (FILE *) 0;
>    int i =3D 0;
>    static const char *list[] =3D { "/tmp/", "/tmp/a", "/tmp/b", NULL };
>    struct stat st;
>
>    while (list[i] !=3D NULL) {
>        if ((fp =3D fopen(list[i], "r")) !=3D NULL) {

should be=20
if ((fp =3D fopen(list[i++], "r")) !=3D NULL) {

>            if (fstat(fileno(fp), &st) !=3D -1) {
>                if ((st.st_mode & (S_IFREG | S_IFLNK)) && st.st_size > 0L)
>                    break;
>            }
>            /* missing:
>            fclose(fp);
>            fp =3D NULL;
>            here */
>        }
>    }
>
>    if (fp)
>        fclose(fp);
>}=