From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 3C2913858D28; Sun, 21 Apr 2024 06:59:55 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3C2913858D28
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1713682795;
	bh=nLai5XMGPXu7xVsO7E+z9eyis3J+zWBCjmCHNezg2Qs=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=U2uvkS6ZNq8fl7NI9JTBh0JROhe/IVzrUF5ibPyG9Gn4jcdYihzjV6A7/EmQpmzdE
	 WD5m0lvA1fdDqe0rJBvZpgt7aV0Zc1seUqbQ0objN8rc1fz09OmTkDZlTYiRDUYZpN
	 lhd6g6VmngxCw1AEPy+wWNhOuqSjByzOQpfnYkPs=
From: "urs at akk dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/114791] analyzer: file-leak not detected
Date: Sun, 21 Apr 2024 06:59:54 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: analyzer
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: urs at akk dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: dmalcolm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-114791-4-crF2hTNbX2@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-114791-4@http.gcc.gnu.org/bugzilla/>
References: <bug-114791-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114791

--- Comment #5 from Urs Jan=C3=9Fen <urs at akk dot org> ---
-Wanalyzer-fd-leak has the same issue, no warning given for:

#define _DEFAULT_SOURCE 1
#include <sys/types.h>
#include <sys/stat.h>
#include <unistd.h>
#include <stdio.h>
#include <fcntl.h>

int main(void);

int main(void) {
    int fd =3D -1;
    int i =3D 0;
    static const char *list[] =3D { "/tmp/", "/tmp/a", "/tmp/b", NULL };
    struct stat st;

    while (list[i] !=3D NULL) {
        if ((fd =3D open(list[i++], O_RDONLY)) !=3D -1) {
            if (fstat(fd, &st) !=3D -1) {
                if ((st.st_mode & (S_IFREG | S_IFLNK)) && st.st_size > 0L)
                    break;
            }
#ifdef NO_FILE_LEAK
            close(fd);
            fd =3D -1;
#endif /* NO_FILE_LEAK */
        }
    }

    if (fd !=3D -1)
        close(fd);
}=