public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/114795] internal compiler error: in finish_member_declaration after module import in gcc 14.0.1 snapshot
Date: Tue, 23 Apr 2024 18:01:50 +0000	[thread overview]
Message-ID: <bug-114795-4-oh2fUOLCWy@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114795-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114795

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:4f9401d1a802325e5dfa2db841945e1a9c59a980

commit r14-10096-g4f9401d1a802325e5dfa2db841945e1a9c59a980
Author: Patrick Palka <ppalka@redhat.com>
Date:   Tue Apr 23 14:01:22 2024 -0400

    c++/modules: deduced return type merging [PR114795]

    When merging an imported function template specialization with an
    existing one, if the existing one has an undeduced return type and the
    imported one's is already deduced, we need to propagate the deduced type
    since once we install the imported definition we won't get a chance to
    deduce it by normal means.

    So this patch makes is_matching_decl propagate the deduced return
    type alongside our propagation of the exception specification.
    Another option would be to propagate it later when installing the
    imported definition from read_function_def, but it seems preferable
    to do it sooner rather than later.

            PR c++/114795

    gcc/cp/ChangeLog:

            * module.cc (trees_in::is_matching_decl): Propagate deduced
            function return type.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/auto-4_a.H: New test.
            * g++.dg/modules/auto-4_b.C: New test.

    Reviewed-by: Jason Merrill <jason@redhat.com>

  parent reply	other threads:[~2024-04-23 18:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-21 14:38 [Bug c++/114795] New: " porten at kde dot org
2024-04-21 22:17 ` [Bug c++/114795] " porten at kde dot org
2024-04-22  0:20 ` porten at kde dot org
2024-04-22  1:52 ` nshead at gcc dot gnu.org
2024-04-22  7:37 ` porten at kde dot org
2024-04-22  8:51 ` nshead at gcc dot gnu.org
2024-04-22 22:49 ` porten at kde dot org
2024-04-23 16:14 ` ppalka at gcc dot gnu.org
2024-04-23 18:01 ` cvs-commit at gcc dot gnu.org [this message]
2024-04-23 18:09 ` ppalka at gcc dot gnu.org
2024-04-24  7:15 ` porten at kde dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114795-4-oh2fUOLCWy@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).