public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "wojciech_mula at poczta dot onet.pl" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/114809] New: [RISC-V RVV] Counting elements might be simpler Date: Mon, 22 Apr 2024 17:10:31 +0000 [thread overview] Message-ID: <bug-114809-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114809 Bug ID: 114809 Summary: [RISC-V RVV] Counting elements might be simpler Product: gcc Version: 14.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: target Assignee: unassigned at gcc dot gnu.org Reporter: wojciech_mula at poczta dot onet.pl Target Milestone: --- Consider this simple procedure --- #include <cstdint> #include <cstdlib> size_t count_chars(const char *src, size_t len, char c) { size_t count = 0; for (size_t i=0; i < len; i++) { count += src[i] == c; } return count; } --- Assembly for it (GCC 14.0, -march=rv64gcv -O3): --- count_chars(char const*, unsigned long, char): beq a1,zero,.L4 vsetvli a4,zero,e8,mf8,ta,ma vmv.v.x v2,a2 vsetvli zero,zero,e64,m1,ta,ma vmv.v.i v1,0 .L3: vsetvli a5,a1,e8,mf8,ta,ma vle8.v v0,0(a0) sub a1,a1,a5 add a0,a0,a5 vmseq.vv v0,v0,v2 vsetvli zero,zero,e64,m1,tu,mu vadd.vi v1,v1,1,v0.t bne a1,zero,.L3 vsetvli a5,zero,e64,m1,ta,ma li a4,0 vmv.s.x v2,a4 vredsum.vs v1,v1,v2 vmv.x.s a0,v1 ret .L4: li a0,0 ret --- The counting procedure might use `vcpop.m` instead of updating vector of counters (`v1`) and summing them in the end. This would move all mode switches outside the loop. And there's a missing peephole optimization: li a4,0 vmv.s.x v2,a4 It can be: vmv.s.x v2,zero
next reply other threads:[~2024-04-22 17:10 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-22 17:10 wojciech_mula at poczta dot onet.pl [this message] 2024-04-22 20:24 ` [Bug target/114809] " palmer at gcc dot gnu.org 2024-04-22 21:11 ` andrew at sifive dot com 2024-04-22 21:59 ` pinskia at gcc dot gnu.org 2024-04-22 22:23 ` juzhe.zhong at rivai dot ai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114809-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).