public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/114821] _M_realloc_append should use memcpy instead of loop to copy data when possible Date: Tue, 23 Apr 2024 11:01:01 +0000 [thread overview] Message-ID: <bug-114821-4-qJRo1CRVO9@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-114821-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114821 --- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> --- If the problem is simply that the __restrict qualifiers are not present because we go through the generic function taking iterators, then we can just add: --- a/libstdc++-v3/include/bits/stl_uninitialized.h +++ b/libstdc++-v3/include/bits/stl_uninitialized.h @@ -1109,8 +1109,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template <typename _Tp, typename _Up> _GLIBCXX20_CONSTEXPR inline __enable_if_t<std::__is_bitwise_relocatable<_Tp>::value, _Tp*> - __relocate_a_1(_Tp* __first, _Tp* __last, - _Tp* __result, + __relocate_a_1(_Tp* __restrict __first, _Tp* __last, + _Tp* __restrict __result, [[__maybe_unused__]] allocator<_Up>& __alloc) noexcept { ptrdiff_t __count = __last - __first; @@ -1147,6 +1147,17 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION std::__niter_base(__result), __alloc); } + template <typename _Tp, typename _Up> + _GLIBCXX20_CONSTEXPR + inline _ForwardIterator + __relocate_a(_Tp* __restrict __first, _Tp* __last, + _Tp* __restrict __result, + [[__maybe_unused__]] allocator<_Up>& __alloc) noexcept + noexcept(std::__is_bitwise_relocatable<_Tp>::value) + { + return std::__relocate_a_1(__first, __last, __result, __alloc); + } + /// @endcond #endif // C++11 If the problem is that std::pair<int, int> is not bitwise_relocatable, then we could change that (as Marc suggested as a possible future enhancement): --- a/libstdc++-v3/include/bits/stl_uninitialized.h +++ b/libstdc++-v3/include/bits/stl_uninitialized.h @@ -1082,6 +1082,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION struct __is_bitwise_relocatable : is_trivial<_Tp> { }; + template<typename _Tp, typename _Up> + struct __is_bitwise_relocatable<pair<_Tp, _Up>, void> + : __and_<is_trivial<_Tp>, is_trivial<_Up>> + { }; + template <typename _InputIterator, typename _ForwardIterator, typename _Allocator> _GLIBCXX20_CONSTEXPR
next prev parent reply other threads:[~2024-04-23 11:01 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-23 8:14 [Bug libstdc++/114821] New: " hubicka at gcc dot gnu.org 2024-04-23 8:30 ` [Bug libstdc++/114821] " redi at gcc dot gnu.org 2024-04-23 8:52 ` hubicka at gcc dot gnu.org 2024-04-23 10:41 ` redi at gcc dot gnu.org 2024-04-23 10:51 ` redi at gcc dot gnu.org 2024-04-23 11:01 ` redi at gcc dot gnu.org [this message] 2024-04-23 12:08 ` hubicka at gcc dot gnu.org 2024-04-23 12:33 ` redi at gcc dot gnu.org 2024-04-23 12:38 ` hubicka at gcc dot gnu.org 2024-04-23 12:41 ` hubicka at gcc dot gnu.org 2024-04-23 12:42 ` redi at gcc dot gnu.org 2024-04-23 13:11 ` redi at gcc dot gnu.org 2024-04-23 15:53 ` redi at gcc dot gnu.org 2024-04-24 14:23 ` hubicka at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114821-4-qJRo1CRVO9@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).