public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/114825] [11/12/13 Regression] Compiler error using gfortran and OpenMP since r5-1190
Date: Thu, 09 May 2024 04:26:34 +0000	[thread overview]
Message-ID: <bug-114825-4-CjfBGarouA@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114825-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114825

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:6d30cfc3fc88976151d0d10e73e10111ccb71ee0

commit r13-8730-g6d30cfc3fc88976151d0d10e73e10111ccb71ee0
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Apr 25 20:09:35 2024 +0200

    openmp: Copy DECL_LANG_SPECIFIC and DECL_LANG_FLAG_? to tree-nested decl
copy [PR114825]

    tree-nested.cc creates in 2 spots artificial VAR_DECLs, one of them is used
    both for debug info and OpenMP/OpenACC lowering purposes, the other solely
for
    OpenMP/OpenACC lowering purposes.
    When the decls are used in OpenMP/OpenACC lowering, the OMP langhooks
(mostly
    Fortran, C just a little and C++ doesn't have nested functions) then
inspect
    the flags on the vars and based on that decide how to lower the
corresponding
    clauses.

    Unfortunately we weren't copying DECL_LANG_SPECIFIC and DECL_LANG_FLAG_?,
so
    the langhooks made decisions on the default flags on those instead.
    As the original decl isn't necessarily a VAR_DECL, could be e.g. PARM_DECL,
    using copy_node wouldn't work properly, so this patch just copies those
    flags in addition to other flags it was copying already.  And I've removed
    code duplication by introducing a helper function which does copying common
    to both uses.

    2024-04-25  Jakub Jelinek  <jakub@redhat.com>

            PR fortran/114825
            * tree-nested.cc (get_debug_decl): New function.
            (get_nonlocal_debug_decl): Use it.
            (get_local_debug_decl): Likewise.

            * gfortran.dg/gomp/pr114825.f90: New test.

    (cherry picked from commit 14d48516e588ad2b35e2007b3970bdcb1b3f145c)

  parent reply	other threads:[~2024-05-09  4:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23 13:33 [Bug libgomp/114825] New: Compiler error using gfortran and OpenMP marcos.vanella at nist dot gov
2024-04-23 14:10 ` [Bug fortran/114825] [11/12/13/14 Regression] Compiler error using gfortran and OpenMP since r5-1190 jakub at gcc dot gnu.org
2024-04-23 14:57 ` burnus at gcc dot gnu.org
2024-04-23 15:18 ` jakub at gcc dot gnu.org
2024-04-24 16:27 ` jakub at gcc dot gnu.org
2024-04-25 18:15 ` cvs-commit at gcc dot gnu.org
2024-04-25 18:23 ` [Bug fortran/114825] [11/12/13 " jakub at gcc dot gnu.org
2024-05-09  4:26 ` cvs-commit at gcc dot gnu.org [this message]
2024-05-09  8:17 ` [Bug fortran/114825] [11/12 " jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114825-4-CjfBGarouA@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).