public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/114908] fails to optimize avx2 in-register permute written with std::experimental::simd
Date: Thu, 02 May 2024 11:12:24 +0000	[thread overview]
Message-ID: <bug-114908-4-SP3DRDSJgr@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114908-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114908

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mkretz at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org
             Target|x86-64-v3                   |x86_64-*-*

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
The memcpy() calls are definitely a hindrance.  I suppose that
update-address-taken could replace some of them with BIT_INSERT_EXPRs but then
it doesn't
handle any calls right now.  Replacing the memcpy on its own would be possible
(special-casing just the "sub-vector" case) like

  __builtin_memcpy (&__r, &data, 24);

to

  _1 = __r;
  _2 = data;
  _3 = VEC_PERM <_2, _1, {0, 1, 2, 7 }>;
  __r = _3;

or if copying a single element using BIT_INSERT_EXPR.  OTOH that's not
good if __r stays in memory (the whole vector store might be good to
avoid STLF fails, but the read will be bad for the same reason).

The update-address-taken pass would know __r and data become registers.
We already have a similar case involving ATOMIC_COMPARE_EXCHANGE that
has delayed processing requring register arguments.  It might or might
not be a good example how to deal with this.

  parent reply	other threads:[~2024-05-02 11:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-01 16:05 [Bug target/114908] New: " lee.imple at gmail dot com
2024-05-01 17:21 ` [Bug target/114908] " pinskia at gcc dot gnu.org
2024-05-01 17:31 ` [Bug tree-optimization/114908] " pinskia at gcc dot gnu.org
2024-05-02 11:12 ` rguenth at gcc dot gnu.org [this message]
2024-05-06  9:05 ` mkretz at gcc dot gnu.org
2024-05-06  9:16 ` rguenther at suse dot de
2024-05-06 10:00 ` mkretz at gcc dot gnu.org
2024-05-06 10:12 ` rguenth at gcc dot gnu.org
2024-05-06 10:30 ` mkretz at gcc dot gnu.org
2024-05-07  3:09 ` lee.imple at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114908-4-SP3DRDSJgr@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).