public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dhylands at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/114928] New: #pragma packed(push,1) should give the same warning as __attribute__((packed))
Date: Thu, 02 May 2024 22:52:00 +0000	[thread overview]
Message-ID: <bug-114928-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114928

            Bug ID: 114928
           Summary: #pragma packed(push,1) should give the same warning as
                    __attribute__((packed))
           Product: gcc
           Version: 13.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dhylands at gmail dot com
  Target Milestone: ---

Created attachment 58091
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58091&action=edit
File that compiles with no warnings

I'm using the ARM Toolchain
arm-gnu-toolchain-13.2.Rel1-x86_64-aarch64-none-linux-gnu/bin/aarch64-none-linux-gnu-g++

running on Ubuntu 20.04

If I delcare my structure using:

struct Foo {
    char y;
    int x;
} __attribute__((packed));

then the compiler correctly gives me a warning about taking the address of a
packed member:

warning: taking address of packed member of ‘Foo’ may result in an unaligned
pointer value [-Waddress-of-packed-member]

However, if I change the structure to use #pragma pack(push, 1) 

#pragma pack(push, 1)
struct Foo {
    char y;
    int x;
};
#pragma pack(pop)

then I don't get the warning (and my bug is that it should give the same
warning).

In either case the member offsets and structure size are the same.

             reply	other threads:[~2024-05-02 22:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 22:52 dhylands at gmail dot com [this message]
2024-05-04  2:09 ` [Bug c++/114928] " egallager at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114928-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).