From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 2E466384AB47; Fri, 3 May 2024 07:41:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2E466384AB47 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1714722115; bh=x2uCVfbRTCuGXYLceoGltQsujogQTa5AgsR3Pl/hQ80=; h=From:To:Subject:Date:In-Reply-To:References:From; b=qXSmeg5P1p2+lEc9RmojwhXm34HbLlpJJffbKVMVNtGzj2eP1EWd69Ld9RxaEHi3p CvKiU3PRCoXWXHsHVDKoLGuO22jkA2yywtsXBfi8UYoufbXOEev/EX8B9k3Z4ieIar WXe5QCwUNzzEwY/DgGGfGhztP5fta3s33TRKya3U= From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c/114931] [14/15 regression] ICE in get_alias_set when building tcl with -std=c23 Date: Fri, 03 May 2024 07:41:54 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 14.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114931 --- Comment #9 from Jakub Jelinek --- Do you really need to hash it on TYPE_CANON, rather than just on whether the type is TYPE_STRUCTURAL_EQUALITY_P or not? I'm worried that always computing the TYPE_CANON before calling type_hash_c= anon is going to be quite expensive, while just figuring out if it should have TYPE_STRUCTURAL_EQUALITY_P or not should be cheaper. If it should have TYPE_STRUCTURAL_EQUALITY_P, we'd SET_TYPE_STRUCTURAL_EQUALITY, otherwise set TYPE_CANONICAL (t) =3D t; (I think that is what we generally get from make_= node), look up and recompute TYPE_CANONICAL if TYPE_CANONICAL (t) =3D=3D t.=