public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/114935] [14/15 regression] Miscompilation of initializer_list<std::string> in presence of exceptions since r14-1705-g2764335bd336f2 Date: Fri, 03 May 2024 20:01:43 +0000 [thread overview] Message-ID: <bug-114935-4-SzoyvYRvbK@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-114935-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114935 --- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-14 branch has been updated by Jason Merrill <jason@gcc.gnu.org>: https://gcc.gnu.org/g:3b4d6b6ecd79df790bf0938dab1f51094f94d777 commit r14-10165-g3b4d6b6ecd79df790bf0938dab1f51094f94d777 Author: Jason Merrill <jason@redhat.com> Date: Fri May 3 09:52:46 2024 -0400 c++: initializer_list<string> and EH [PR114935] When we initialize an array of a type with a non-trivial destructor, such as the backing array for the initializer_list, we have a cleanup to destroy any constructed elements if a later constructor throws. When the array being created is a variable, the end of that EH region naturally coincides with the beginning of the EH region for the cleanup for the variable as a whole. But if the array is a temporary, or a subobject of one, the array cleanup region lasts for the rest of the full-expression, along with the normal cleanup for the TARGET_EXPR. As a result, when tata throws we clean it up twice. Before r14-1705 we avoided this by disabling the array cleanup in split_nonconstant_init, but after that we don't go through split_nonconstant_init, so let's handle it in cp_genericize_target_expr. PR c++/114935 gcc/cp/ChangeLog: * cp-gimplify.cc (cp_genericize_init): Add flags parm. (cp_genericize_init_expr): Pass nullptr. (cp_genericize_target_expr): Handle cleanup flags. * typeck2.cc (build_disable_temp_cleanup): Factor out of... (split_nonconstant_init): ...here. * cp-tree.h (build_disable_temp_cleanup): Declare. gcc/testsuite/ChangeLog: * g++.dg/cpp0x/initlist-eh1.C: New test. (cherry picked from commit 8f3afb83c879f1bfa722a963a07c06aaf174ef72)
next prev parent reply other threads:[~2024-05-03 20:01 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-05-03 12:18 [Bug c++/114935] New: Miscompilation of initializer_list<std::string> in presence of exceptions jamborm at gcc dot gnu.org 2024-05-03 12:19 ` [Bug c++/114935] [14/15 regression] " jason at gcc dot gnu.org 2024-05-03 16:23 ` [Bug c++/114935] [14/15 regression] Miscompilation of initializer_list<std::string> in presence of exceptions since r14-1705-g2764335bd336f2 jason at gcc dot gnu.org 2024-05-03 20:01 ` cvs-commit at gcc dot gnu.org 2024-05-03 20:01 ` cvs-commit at gcc dot gnu.org [this message] 2024-05-03 20:02 ` jason at gcc dot gnu.org 2024-05-14 21:44 ` jason at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114935-4-SzoyvYRvbK@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).