From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 24405384CBA1; Wed, 15 May 2024 20:49:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24405384CBA1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1715806146; bh=BSJ8RUIZQo7vtrVV1ODKCLDQGX6i4z5QKgo2O4TG8Ao=; h=From:To:Subject:Date:In-Reply-To:References:From; b=tNdyIA3RFiQGvJKra+bGtFXxmvYYOQ1K+NtXJXjrxpTofgM7M2tvSc/RRGW/qIglg 6R/H6psXFTgYm/sUW6XX75j7eAs1yNlkSdo2/BOoAUEN6YgKtQDN1LUBfCjGghwLIX T2bsgcM5E1wBs84beYWBDBs5220zYj/5Ec7cAGcY= From: "jamborm at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/114985] [15 regression] internal compiler error: in discriminator_fail during stage2 Date: Wed, 15 May 2024 20:49:04 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: ipa X-Bugzilla-Version: 15.0 X-Bugzilla-Keywords: needs-reduction X-Bugzilla-Severity: normal X-Bugzilla-Who: jamborm at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 15.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114985 --- Comment #20 from Martin Jambor --- The IL we generate the jump function from is: _1 =3D cclauses_2(D) !=3D 0B; c_parser_omp_all_clauses (_1); Which translates to the expected jump function: callsite void c_parser_omp_teams(int**)/3 -> int* c_parser_omp_all_clauses(bool)/1 : param 0: PASS THROUGH: 0, op ne_expr 0B so IPA looks like it's doing what it should. (In reply to Aldy Hernandez from comment #6) > I wonder if something like this would work. >=20 > diff --git a/gcc/ipa-cp.cc b/gcc/ipa-cp.cc > index 5781f50..ea8a685 100644 > --- a/gcc/ipa-cp.cc > +++ b/gcc/ipa-cp.cc > @@ -1730,6 +1730,8 @@ ipa_value_range_from_jfunc (vrange &vr, > } > else > { > + if (TREE_CODE_CLASS (operation) =3D=3D tcc_comparison) > + vr_type =3D boolean_type_node; > Value_Range op_res (vr_type); > Value_Range res (vr_type); > tree op =3D ipa_get_jf_pass_through_operand (jfunc); This looks OKish and we also do a similar thing in ipa_get_jf_arith_result. Also note that the ipa_value_range_from_jfunc already has a parameter that tells it what type the result should be. It is called parm_type, which is boolean_type in the case that ICEs. So we can even bail out if we really encounter jump function created from bad IL. I was thinking of using use parm_type from the beginning, to initialize op_res with it, but there are jump functions representing an operation followed by a truncation, for example for: _2 =3D complain_6(D) & 1; _3 =3D (int) std_alignof_7(D); cxx_sizeof_or_alignof_type (_3, _2); where _r is in fact bool (has smaller size and precision) and trying to make ranger do the bit_and_expr directly to bool leads to a failed assert in fold_range (the test of m_operator->operand_check_p). So doing the operation in the original type - unless it is a comparison - and then using ipa_vr_operation_and_type_effects seems to be the right thing to do. But I am really curious why propagate_vr_across_jump_function does not need the same check for tcc_comparison operators and generally why is it so different (in the non-scc case)? Why is ipa_supports_p (this predicate has a really really really bad name BTW and I am completely at loss as to what it does and how or why) used there and not in ipa_value_range_from_jfunc? (I also cannot prevent myself from ranting a little that it would really help if all the ranger (helper) classes and functions were better documented.)=