public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/114985] [15 regression] internal compiler error: in discriminator_fail during stage2 Date: Thu, 16 May 2024 09:59:45 +0000 [thread overview] Message-ID: <bug-114985-4-5UJ0x628fn@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-114985-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114985 --- Comment #24 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Aldy Hernandez <aldyh@gcc.gnu.org>: https://gcc.gnu.org/g:b8e3574e68310f68116f157a35d5650600d13718 commit r15-574-gb8e3574e68310f68116f157a35d5650600d13718 Author: Aldy Hernandez <aldyh@redhat.com> Date: Thu May 16 09:47:56 2024 +0200 Cleanup prange sanity checks. The pointers_handled_p() code was a temporary sanity check, and not even a good one, since we have a cleaner way of checking type mismatches with operand_check_p. This patch removes all the code, and adds an explicit type check for relational operators, which are the main problem in PR114985. Adding this check makes it clear where the type mismatch is happening in IPA, even without prange. I've added code to skip the range folding if the types don't match what the operator expects. In order to reproduce the latent bug, just remove the operand_check_p calls. Tested on x86-64 and ppc64le with and without prange support. gcc/ChangeLog: PR tree-optimization/114985 * gimple-range-op.cc: Remove pointers_handled_p. * ipa-cp.cc (ipa_value_range_from_jfunc): Skip range folding if operands don't match. (propagate_vr_across_jump_function): Same. * range-op-mixed.h: Remove pointers_handled_p and tweak operand_check_p. * range-op-ptr.cc (range_operator::pointers_handled_p): Remove. (pointer_plus_operator::pointers_handled_p): Remove. (class operator_pointer_diff): Remove pointers_handled_p. (operator_pointer_diff::pointers_handled_p): Remove. (operator_identity::pointers_handled_p): Remove. (operator_cst::pointers_handled_p): Remove. (operator_cast::pointers_handled_p): Remove. (operator_min::pointers_handled_p): Remove. (operator_max::pointers_handled_p): Remove. (operator_addr_expr::pointers_handled_p): Remove. (operator_bitwise_and::pointers_handled_p): Remove. (operator_bitwise_or::pointers_handled_p): Remove. (operator_equal::pointers_handled_p): Remove. (operator_not_equal::pointers_handled_p): Remove. (operator_lt::pointers_handled_p): Remove. (operator_le::pointers_handled_p): Remove. (operator_gt::pointers_handled_p): Remove. (operator_ge::pointers_handled_p): Remove. * range-op.cc (TRAP_ON_UNHANDLED_POINTER_OPERATORS): Remove. (range_op_handler::lhs_op1_relation): Remove pointers_handled_p checks. (range_op_handler::lhs_op2_relation): Same. (range_op_handler::op1_op2_relation): Same. * range-op.h: Remove RO_* declarations.
next prev parent reply other threads:[~2024-05-16 9:59 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-05-08 12:59 [Bug bootstrap/114985] New: " seurer at gcc dot gnu.org 2024-05-08 15:00 ` [Bug bootstrap/114985] " seurer at gcc dot gnu.org 2024-05-08 15:35 ` aldyh at gcc dot gnu.org 2024-05-08 16:34 ` seurer at gcc dot gnu.org 2024-05-08 16:34 ` aldyh at gcc dot gnu.org 2024-05-08 17:06 ` [Bug ipa/114985] " pinskia at gcc dot gnu.org 2024-05-08 20:33 ` aldyh at gcc dot gnu.org 2024-05-08 22:28 ` seurer at gcc dot gnu.org 2024-05-09 14:21 ` seurer at gcc dot gnu.org 2024-05-09 16:27 ` dje at gcc dot gnu.org 2024-05-09 21:54 ` aldyh at gcc dot gnu.org 2024-05-09 22:36 ` aldyh at gcc dot gnu.org 2024-05-10 9:27 ` aldyh at gcc dot gnu.org 2024-05-10 12:13 ` ro at CeBiTec dot Uni-Bielefeld.DE 2024-05-10 12:49 ` hubicka at gcc dot gnu.org 2024-05-10 14:38 ` segher at gcc dot gnu.org 2024-05-10 16:15 ` jamborm at gcc dot gnu.org 2024-05-11 9:47 ` aldyh at gcc dot gnu.org 2024-05-11 9:48 ` aldyh at gcc dot gnu.org 2024-05-13 14:06 ` jamborm at gcc dot gnu.org 2024-05-15 20:49 ` jamborm at gcc dot gnu.org 2024-05-15 21:06 ` amacleod at redhat dot com 2024-05-16 8:16 ` aldyh at gcc dot gnu.org 2024-05-16 9:59 ` cvs-commit at gcc dot gnu.org 2024-05-16 9:59 ` cvs-commit at gcc dot gnu.org [this message] 2024-05-16 10:07 ` aldyh at gcc dot gnu.org 2024-05-16 10:58 ` ro at CeBiTec dot Uni-Bielefeld.DE 2024-05-16 11:49 ` aldyh at gcc dot gnu.org 2024-05-16 11:58 ` ro at CeBiTec dot Uni-Bielefeld.DE 2024-05-16 12:50 ` aldyh at gcc dot gnu.org 2024-05-16 12:56 ` aldyh at gcc dot gnu.org 2024-05-16 13:04 ` ro at CeBiTec dot Uni-Bielefeld.DE 2024-05-16 14:24 ` aldyh at gcc dot gnu.org 2024-05-16 19:06 ` segher at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114985-4-5UJ0x628fn@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).