[Bug libstdc++/115119] New: Typo in _Grapheme_cluster_view::_Iterator::operator++(int)

[Bug libstdc++/115119] New: Typo in _Grapheme_cluster_view::_Iterator::operator++(int)

[davidfromonline at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119

            Bug ID: 115119
           Summary: Typo in
                    _Grapheme_cluster_view::_Iterator::operator++(int)
           Product: gcc
           Version: 14.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: davidfromonline at gmail dot com
  Target Milestone: ---

The following code in unicode.h:

```c++
        constexpr _Iterator
        operator++(int)
        {
          auto __tmp = *this;
          ++this;
          return __tmp;
        }
```


Should instead be:

```c++
        constexpr _Iterator
        operator++(int)
        {
          auto __tmp = *this;
          ++*this;
          return __tmp;
        }
```

(`++*this` instead of `++this`).

[Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
No ++this is correct. We want to increment the iterator and not the what the
iterator points too here.

[Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2024-05-16

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Which would be ++*this

++this shouldn't even compile.

[Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
It fails to compile if that member function is instantiated (which libstdc++
itself never does).

/home/jwakely/gcc/15/include/c++/15.0.0/bits/unicode.h:805:11: error: increment
of read-only location
'(std::__unicode::__v15_1_0::_Grapheme_cluster_view<std::basic_string_view<char>
>::_Iterator*)this'
  805 |           ++this;
      |           ^~~~~~
/home/jwakely/gcc/15/include/c++/15.0.0/bits/unicode.h:805:11: error: lvalue
required as increment operand


But ++this could be rejected without treating it as a dependent expression.

Anyway, I'll fix the library typo.

[Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=115121

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I've opened PR 115121 for the accepts-invalid compiler bug.

[Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rl.alt.accnt at gmail dot com

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
*** Bug 115124 has been marked as a duplicate of this bug. ***

[Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pilarlatiesa at gmail dot com

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
*** Bug 115134 has been marked as a duplicate of this bug. ***

[Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:c9e05b03c18e898be604ab90401476e9c473cc52

commit r15-629-gc9e05b03c18e898be604ab90401476e9c473cc52
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu May 16 17:15:55 2024 +0100

    libstdc++: Fix typo in _Grapheme_cluster_view::_Iterator [PR115119]

    libstdc++-v3/ChangeLog:

            PR libstdc++/115119
            * include/bits/unicode.h (_Iterator::operator++(int)): Fix typo
            in increment expression.
            * testsuite/ext/unicode/grapheme_view.cc: Check post-increment
            on view's iterator.

[Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:e909d360dfaeafa9f45eda2461a1bedffac99ac2

commit r14-10215-ge909d360dfaeafa9f45eda2461a1bedffac99ac2
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu May 16 17:15:55 2024 +0100

    libstdc++: Fix typo in _Grapheme_cluster_view::_Iterator [PR115119]

    libstdc++-v3/ChangeLog:

            PR libstdc++/115119
            * include/bits/unicode.h (_Iterator::operator++(int)): Fix typo
            in increment expression.
            * testsuite/ext/unicode/grapheme_view.cc: Check post-increment
            on view's iterator.

    (cherry picked from commit c9e05b03c18e898be604ab90401476e9c473cc52)

[Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |14.2

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 14.2, thanks for the report (and to the dup reporters).