* [Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)
2024-05-16 15:43 [Bug libstdc++/115119] New: Typo in _Grapheme_cluster_view::_Iterator::operator++(int) davidfromonline at gmail dot com
@ 2024-05-16 15:46 ` pinskia at gcc dot gnu.org
2024-05-16 15:56 ` redi at gcc dot gnu.org
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-05-16 15:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
No ++this is correct. We want to increment the iterator and not the what the
iterator points too here.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)
2024-05-16 15:43 [Bug libstdc++/115119] New: Typo in _Grapheme_cluster_view::_Iterator::operator++(int) davidfromonline at gmail dot com
2024-05-16 15:46 ` [Bug libstdc++/115119] " pinskia at gcc dot gnu.org
@ 2024-05-16 15:56 ` redi at gcc dot gnu.org
2024-05-16 16:00 ` redi at gcc dot gnu.org
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: redi at gcc dot gnu.org @ 2024-05-16 15:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
Last reconfirmed| |2024-05-16
--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Which would be ++*this
++this shouldn't even compile.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)
2024-05-16 15:43 [Bug libstdc++/115119] New: Typo in _Grapheme_cluster_view::_Iterator::operator++(int) davidfromonline at gmail dot com
2024-05-16 15:46 ` [Bug libstdc++/115119] " pinskia at gcc dot gnu.org
2024-05-16 15:56 ` redi at gcc dot gnu.org
@ 2024-05-16 16:00 ` redi at gcc dot gnu.org
2024-05-16 16:20 ` redi at gcc dot gnu.org
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: redi at gcc dot gnu.org @ 2024-05-16 16:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
It fails to compile if that member function is instantiated (which libstdc++
itself never does).
/home/jwakely/gcc/15/include/c++/15.0.0/bits/unicode.h:805:11: error: increment
of read-only location
'(std::__unicode::__v15_1_0::_Grapheme_cluster_view<std::basic_string_view<char>
>::_Iterator*)this'
805 | ++this;
| ^~~~~~
/home/jwakely/gcc/15/include/c++/15.0.0/bits/unicode.h:805:11: error: lvalue
required as increment operand
But ++this could be rejected without treating it as a dependent expression.
Anyway, I'll fix the library typo.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)
2024-05-16 15:43 [Bug libstdc++/115119] New: Typo in _Grapheme_cluster_view::_Iterator::operator++(int) davidfromonline at gmail dot com
` (2 preceding siblings ...)
2024-05-16 16:00 ` redi at gcc dot gnu.org
@ 2024-05-16 16:20 ` redi at gcc dot gnu.org
2024-05-16 18:26 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: redi at gcc dot gnu.org @ 2024-05-16 16:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://gcc.gnu.org/bugzill
| |a/show_bug.cgi?id=115121
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I've opened PR 115121 for the accepts-invalid compiler bug.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)
2024-05-16 15:43 [Bug libstdc++/115119] New: Typo in _Grapheme_cluster_view::_Iterator::operator++(int) davidfromonline at gmail dot com
` (3 preceding siblings ...)
2024-05-16 16:20 ` redi at gcc dot gnu.org
@ 2024-05-16 18:26 ` jakub at gcc dot gnu.org
2024-05-17 12:43 ` redi at gcc dot gnu.org
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-05-16 18:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rl.alt.accnt at gmail dot com
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
*** Bug 115124 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)
2024-05-16 15:43 [Bug libstdc++/115119] New: Typo in _Grapheme_cluster_view::_Iterator::operator++(int) davidfromonline at gmail dot com
` (4 preceding siblings ...)
2024-05-16 18:26 ` jakub at gcc dot gnu.org
@ 2024-05-17 12:43 ` redi at gcc dot gnu.org
2024-05-17 12:47 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: redi at gcc dot gnu.org @ 2024-05-17 12:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pilarlatiesa at gmail dot com
--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
*** Bug 115134 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)
2024-05-16 15:43 [Bug libstdc++/115119] New: Typo in _Grapheme_cluster_view::_Iterator::operator++(int) davidfromonline at gmail dot com
` (5 preceding siblings ...)
2024-05-17 12:43 ` redi at gcc dot gnu.org
@ 2024-05-17 12:47 ` cvs-commit at gcc dot gnu.org
2024-05-17 13:17 ` cvs-commit at gcc dot gnu.org
2024-05-17 13:19 ` redi at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-05-17 12:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119
--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:c9e05b03c18e898be604ab90401476e9c473cc52
commit r15-629-gc9e05b03c18e898be604ab90401476e9c473cc52
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Thu May 16 17:15:55 2024 +0100
libstdc++: Fix typo in _Grapheme_cluster_view::_Iterator [PR115119]
libstdc++-v3/ChangeLog:
PR libstdc++/115119
* include/bits/unicode.h (_Iterator::operator++(int)): Fix typo
in increment expression.
* testsuite/ext/unicode/grapheme_view.cc: Check post-increment
on view's iterator.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)
2024-05-16 15:43 [Bug libstdc++/115119] New: Typo in _Grapheme_cluster_view::_Iterator::operator++(int) davidfromonline at gmail dot com
` (6 preceding siblings ...)
2024-05-17 12:47 ` cvs-commit at gcc dot gnu.org
@ 2024-05-17 13:17 ` cvs-commit at gcc dot gnu.org
2024-05-17 13:19 ` redi at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-05-17 13:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119
--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:e909d360dfaeafa9f45eda2461a1bedffac99ac2
commit r14-10215-ge909d360dfaeafa9f45eda2461a1bedffac99ac2
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Thu May 16 17:15:55 2024 +0100
libstdc++: Fix typo in _Grapheme_cluster_view::_Iterator [PR115119]
libstdc++-v3/ChangeLog:
PR libstdc++/115119
* include/bits/unicode.h (_Iterator::operator++(int)): Fix typo
in increment expression.
* testsuite/ext/unicode/grapheme_view.cc: Check post-increment
on view's iterator.
(cherry picked from commit c9e05b03c18e898be604ab90401476e9c473cc52)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug libstdc++/115119] Typo in _Grapheme_cluster_view::_Iterator::operator++(int)
2024-05-16 15:43 [Bug libstdc++/115119] New: Typo in _Grapheme_cluster_view::_Iterator::operator++(int) davidfromonline at gmail dot com
` (7 preceding siblings ...)
2024-05-17 13:17 ` cvs-commit at gcc dot gnu.org
@ 2024-05-17 13:19 ` redi at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: redi at gcc dot gnu.org @ 2024-05-17 13:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115119
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Target Milestone|--- |14.2
--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 14.2, thanks for the report (and to the dup reporters).
^ permalink raw reply [flat|nested] 10+ messages in thread