public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/115152] [13/14/15 Regression] wrong code at -O3 with "-fno-tree-fre -fno-tree-dominator-opts -fno-tree-loop-im" on x86_64-linux-gnu since r13-455
Date: Wed, 22 May 2024 07:19:59 +0000	[thread overview]
Message-ID: <bug-115152-4-6YRUbFxQPY@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-115152-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115152

--- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:fc9fb69ad624fd4cc89ff31ad0a7b8d88481c1f7

commit r14-10231-gfc9fb69ad624fd4cc89ff31ad0a7b8d88481c1f7
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed May 22 09:13:50 2024 +0200

    strlen: Fix up !si->full_string_p handling in count_nonzero_bytes_addr
[PR115152]

    The following testcase is miscompiled because
    strlen_pass::count_nonzero_bytes_addr doesn't handle correctly
    the !si->full_string_p case.
    If si->full_string_p, it correctly computes minlen and maxlen as
    minimum and maximum length of the '\0' terminated stgring and
    clears *nulterm (ie. makes sure !full_string_p in the ultimate
    caller) if minlen is equal or larger than nbytes and so
    '\0' isn't guaranteed to be among those bytes.
    But in the !si->full_string_p case, all we know is that there
    are [minlen,maxlen] non-zero bytes followed by unknown bytes,
    so effectively the maxlen is infinite (but caller cares about only
    the first nbytes bytes) and furthermore, we never know if there is
    any '\0' char among those, so *nulterm needs to be always cleared.

    2024-05-22  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/115152
            * tree-ssa-strlen.cc (strlen_pass::count_nonzero_bytes_addr): If
            !si->full_string_p, clear *nulterm and set maxlen to nbytes.

            * gcc.dg/pr115152.c: New test.

    (cherry picked from commit dbc9b45a3c2468ad134b3a9bd4961f7ae6bc1e67)

  parent reply	other threads:[~2024-05-22  7:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-18 20:22 [Bug tree-optimization/115152] New: wrong code at -O3 with "-fno-tree-fre -fno-tree-dominator-opts -fno-tree-loop-im" on x86_64-linux-gnu zhendong.su at inf dot ethz.ch
2024-05-18 21:40 ` [Bug tree-optimization/115152] [13/14/15 Regression] " pinskia at gcc dot gnu.org
2024-05-18 21:40 ` pinskia at gcc dot gnu.org
2024-05-18 21:53 ` pinskia at gcc dot gnu.org
2024-05-18 21:54 ` pinskia at gcc dot gnu.org
2024-05-20 18:27 ` [Bug tree-optimization/115152] [13/14/15 Regression] wrong code at -O3 with "-fno-tree-fre -fno-tree-dominator-opts -fno-tree-loop-im" on x86_64-linux-gnu since r13-455 jakub at gcc dot gnu.org
2024-05-20 18:36 ` jakub at gcc dot gnu.org
2024-05-21  6:38 ` rguenth at gcc dot gnu.org
2024-05-21  9:20 ` jakub at gcc dot gnu.org
2024-05-21 11:57 ` jakub at gcc dot gnu.org
2024-05-22  7:14 ` cvs-commit at gcc dot gnu.org
2024-05-22  7:19 ` cvs-commit at gcc dot gnu.org [this message]
2024-05-22  7:35 ` cvs-commit at gcc dot gnu.org
2024-05-22 11:11 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-115152-4-6YRUbFxQPY@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).