From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 4AD533858C78; Tue, 21 May 2024 14:25:58 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4AD533858C78
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1716301558;
	bh=7hbE6Q7kz0sf9EzqGQashV+nt7c/qBLIxeGfOKtEvLM=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=VUDhzZ54Syyzsmth8qaP92f3jPej5M3OFk8ofZrB2/QnvsY5mwrYuNtDfUAMLFElT
	 L/iKTJlnLLaLtYP9EKFwBChw+H6VIRyV3kiwBhFFKmMYV1H91dNZg7o9I8MP+jL/+g
	 i6gKnoH0nOXY6d7+PMaVDtvgRTQ7ECxbXydwo/p0=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/115154] [13/14/15 Regression] wrong code at
 optimization levels -O2, -O3, -Os since r13-7434-g682bbd364708fe
Date: Tue, 21 May 2024 14:25:58 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 13.2.0
X-Bugzilla-Keywords: patch, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: pinskia at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-115154-4-eO2bSEvYqs@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-115154-4@http.gcc.gnu.org/bugzilla/>
References: <bug-115154-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D115154

--- Comment #17 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Andrew Pinski
<pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:b2bb49d6a77e4568c0b91db17b2599f5929fb85b

commit r14-10224-gb2bb49d6a77e4568c0b91db17b2599f5929fb85b
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Mon May 20 00:16:40 2024 -0700

    match: Disable `(type)zero_one_valuep*CST` for 1bit signed types [PR115=
154]

    The problem here is the pattern added in r13-1162-g9991d84d2a8435
    assumes that it is well defined to multiply zero_one_valuep by the
truncated
    converted integer constant. It is well defined for all types except for
signed 1bit types.
    Where `a * -1` is produced which is undefined/
    So disable this pattern for 1bit signed types.

    Note the pattern added in r14-3432-gddd64a6ec3b38e is able to workaround
the undefinedness except when
    `-fsanitize=3Dundefined` is turned on, this is why I added a testcase f=
or
that.

    Bootstrapped and tested on x86_64-linux-gnu with no regressions.

            PR tree-optimization/115154

    gcc/ChangeLog:

            * match.pd (convert (mult zero_one_valued_p@1 INTEGER_CST@2)):
Disable
            for 1bit signed types.

    gcc/testsuite/ChangeLog:

            * c-c++-common/ubsan/signed1bitfield-1.c: New test.
            * gcc.c-torture/execute/signed1bitfield-1.c: New test.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
    (cherry picked from commit 49c87d22535ac4f8aacf088b3f462861c26cacb4)=