public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/115160] Enabling undefined behaviour sanitizer causes or'ed bit shift to report wrong result
Date: Tue, 21 May 2024 11:46:33 +0000	[thread overview]
Message-ID: <bug-115160-4-XGwzLmn01M@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-115160-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115160

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Specifically, std::vector<uint8_t>::iterator::operator++(int) is "just a
function", so the compiler doesn't "know" that it modifies the iterator every
time it's called. To the compiler, the code looks like:

(deref(inc(b)) | (deref(inc(b)) << 8) | (deref(inc(b)) << 16) | (deref(inc(b))
<< 24)

And this isn't clear that this modifies b and that the result depends on the
unspecified order that each deref(inc(b)) subexpression is evaluated.

But that doesn't really matter anyway. I don't think there is actually any
undefined behaviour here at all, so UBsan should not give any errors.
Evaluation of each *b++ subexpression happens before the evaluation of the next
one. But the standard doesn't specify which one is "the next one". It's not
undefined, but it's unspecified. So it's valid for the compiler to evaluate it
left-to-right, but also valid to evaluate it right-to-left, or any other order
as long as the b++ evaluations do not interleave.

  parent reply	other threads:[~2024-05-21 11:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20 10:03 [Bug c++/115160] New: " raanan.lori at getnexar dot com
2024-05-20 17:56 ` [Bug c++/115160] " jakub at gcc dot gnu.org
2024-05-21  9:41 ` raanan.lori at getnexar dot com
2024-05-21  9:53 ` jakub at gcc dot gnu.org
2024-05-21 10:07 ` raanan.lori at getnexar dot com
2024-05-21 11:46 ` redi at gcc dot gnu.org [this message]
2024-05-21 12:09 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-115160-4-XGwzLmn01M@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).