From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id ED8A4385C6C9; Thu, 18 Jul 2024 03:07:56 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED8A4385C6C9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1721272076;
	bh=VUl2VaFj/67Dc4DqyHFPYSjUsJv547bavGpfo5wwcus=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=tJXEEB/Ephgk5fPq3J+Nv/Y76rZEhnGzBzttx+wH9ovGUVKbtblqQt7lR76mfxEQ8
	 8UpV5geSJHCCWVMpncnxPOn83tbky5E9vPdbr5DxoCu/x/iZrlqyAZO9bq9j0iaOff
	 QIlTSKl7V2EYneQPW2q2JJYY/WSfJjeMvWSkWr44=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/115165] ICE on -ftime-report with module and c++2b
Date: Thu, 18 Jul 2024 03:07:56 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-115165-4-cJRAedJFnA@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-115165-4@http.gcc.gnu.org/bugzilla/>
References: <bug-115165-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D115165

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathaniel Shead <nshead@gcc.gnu.org>:

https://gcc.gnu.org/g:b7b2434cc7e712dc5055bde02c441393ae881f06

commit r15-2121-gb7b2434cc7e712dc5055bde02c441393ae881f06
Author: Nathaniel Shead <nathanieloshead@gmail.com>
Date:   Sun Jul 7 23:19:52 2024 +1000

    c++/modules: Conditionally start timer during lazy load [PR115165]

    While lazy loading, instantiation of pendings can sometimes recursively
    perform name lookup and begin further lazy loading.  When using the
    '-ftime-report' functionality this causes ICEs as we could start an
    already-running timer for the importing.

    This patch fixes the issue by using the 'timevar_cond*' API instead to
    support such recursive calls.

            PR c++/115165

    gcc/cp/ChangeLog:

            * module.cc (lazy_load_binding): Use 'timevar_cond*' APIs.
            (lazy_load_pendings): Likewise.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/timevar-1_a.H: New test.
            * g++.dg/modules/timevar-1_b.C: New test.

    Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>=