public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/115176] rbit pattern should use bitreverse rtl now
Date: Wed, 12 Jun 2024 16:12:20 +0000	[thread overview]
Message-ID: <bug-115176-4-FGyZDnDTOe@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-115176-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115176

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:c2f0aaf7539c42b024ed6b3fb6909bd2c86bb206

commit r15-1216-gc2f0aaf7539c42b024ed6b3fb6909bd2c86bb206
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Tue Jun 11 20:36:34 2024 +0000

    aarch64: Use bitreverse rtl code instead of unspec [PR115176]

    Bitreverse rtl code was added with r14-1586-g6160572f8d243c. So let's
    use it instead of an unspec. This is just a small cleanup but it does
    have one small fix with respect to rtx costs which didn't handle vector
modes
    correctly for the UNSPEC and now it does.
    This is part of the first step in adding __builtin_bitreverse's builtins
    but it is independent of it though.

    Bootstrapped and tested on aarch64-linux-gnu with no regressions.

    gcc/ChangeLog:

            PR target/115176
            * config/aarch64/aarch64-simd.md
(aarch64_rbit<mode><vczle><vczbe>): Use
            bitreverse instead of unspec.
            * config/aarch64/aarch64-sve-builtins-base.cc (svrbit): Convert
over to using
            rtx_code_function instead of unspec_based_function.
            * config/aarch64/aarch64-sve.md: Update comment where RBIT is
included.
            * config/aarch64/aarch64.cc (aarch64_rtx_costs): Handle BITREVERSE
like BSWAP.
            Remove UNSPEC_RBIT support.
            * config/aarch64/aarch64.md (unspec): Remove UNSPEC_RBIT.
            (aarch64_rbit<mode>): Use bitreverse instead of unspec.
            * config/aarch64/iterators.md (SVE_INT_UNARY): Add bitreverse.
            (optab): Likewise.
            (sve_int_op): Likewise.
            (SVE_INT_UNARY): Remove UNSPEC_RBIT.
            (optab): Likewise.
            (sve_int_op): Likewise.
            (min_elem_bits): Likewise.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>

  parent reply	other threads:[~2024-06-12 16:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 15:19 [Bug target/115176] New: " pinskia at gcc dot gnu.org
2024-05-21 15:21 ` [Bug target/115176] " pinskia at gcc dot gnu.org
2024-05-22  1:06 ` xry111 at gcc dot gnu.org
2024-06-12  0:03 ` pinskia at gcc dot gnu.org
2024-06-12 16:12 ` cvs-commit at gcc dot gnu.org [this message]
2024-06-12 16:12 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-115176-4-FGyZDnDTOe@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).