public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dmalcolm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/115203] [15 Regression] Build fail with non LANG=C in analyzer self test: ICE in fail_formatted at selftest.cc:63 / tree-diagnostic-path.cc:2158: test_control_flow_5: FAIL: ASSERT_STREQ
Date: Thu, 23 May 2024 14:11:41 +0000	[thread overview]
Message-ID: <bug-115203-4-2CMh0YcMNO@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-115203-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115203

--- Comment #3 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
(In reply to Tobias Burnus from comment #2)
> Thus, one way would be to have LANG=C set somewhere (e.g. via the Makefile -
> assuming it can be done portable). 

I'd prefer not to do that as we may want to have selftests of i18n (though
libintl seems to have a lot of global state, which is a pain for selftests).

> Alternative would be your suggestion to disable it in simple_diagnostic_path.

I have a patch for that; it seems to work.

> Looking at gcc/intl.cc's gcc_init_libintl, you also need to watch out for
> open_quote/close_quote and other fun changes as they might come before you
> switch to to LANG=C.

FWIW we already have class auto_fix_quotes for that (see selftest.h)

  parent reply	other threads:[~2024-05-23 14:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-23 11:04 [Bug analyzer/115203] New: " burnus at gcc dot gnu.org
2024-05-23 12:41 ` [Bug analyzer/115203] " rguenth at gcc dot gnu.org
2024-05-23 13:39 ` dmalcolm at gcc dot gnu.org
2024-05-23 13:49 ` burnus at gcc dot gnu.org
2024-05-23 14:11 ` dmalcolm at gcc dot gnu.org [this message]
2024-05-28 17:08 ` cvs-commit at gcc dot gnu.org
2024-05-28 17:14 ` dmalcolm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-115203-4-2CMh0YcMNO@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).