[Bug middle-end/115208] New: [15 Regression] Memory consumption get extremely high after r15-809

[Bug middle-end/115208] New: [15 Regression] Memory consumption get extremely high after r15-809

[haochen.jiang at intel dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

            Bug ID: 115208
           Summary: [15 Regression] Memory consumption get extremely high
                    after r15-809
           Product: gcc
           Version: 15.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: haochen.jiang at intel dot com
  Target Milestone: ---

I currently got some testcase fail on i686 target.

New failures:
FAIL: gcc.target/i386/avx-1.c (test for excess errors)
FAIL: gcc.target/i386/sse-13.c (test for excess errors)
FAIL: gcc.target/i386/sse-23.c (test for excess errors)
FAIL: gcc.target/i386/sse-24.c (test for excess errors)
FAIL: gcc.target/i386/sse-25.c (test for excess errors)
FAIL: gcc.target/i386/sse-26.c (test for excess errors)

From my investigation, it happened after the commit series r15-797 to r15-809.

After those commits, the memory consumption got very high.

I ran with:
make check-gcc RUNTESTFLAGS="i386.exp=avx-1.c --target_board='unix{-m32}'"

Before those commits, the memory usage:

Memory usage summary: heap total: 245591, heap peak: 205651, stack peak: 13824
         total calls   total memory   failed calls
 malloc|        402         238998              0
realloc|         14           5416              0  (nomove:7, dec:0, free:0)
 calloc|          6           1177              0
   free|        224          57705

After those commits, the memory usage:

Memory usage summary: heap total: 17691252434, heap peak: 7691866921, stack
peak: 51056
         total calls   total memory   failed calls
 malloc|   69614075    15426859093              0
realloc|     260731       17538362              0  (nomove:88951, dec:19349,
free:0)
 calloc|   11132073     2246854979              0
   free|   81105599     9997315310


Since i686 target gets very limited memory, it crashed those targets.

[Bug middle-end/115208] [15 Regression] Memory consumption get extremely high after r15-809

[haochen.jiang at intel dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

--- Comment #1 from Haochen Jiang <haochen.jiang at intel dot com> ---
Forgot to mention, the memory consumption collection is collected on x86_64
target in order to get the test finished. Therefore, we could debug on x86_64.

[Bug tree-optimization/115208] [15 Regression] Memory consumption get extremely high after r15-809

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|middle-end                  |tree-optimization
   Target Milestone|---                         |15.0

[Bug tree-optimization/115208] [15 Regression] Memory consumption get extremely high after r15-809

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug tree-optimization/115208] [15 Regression] Memory consumption get extremely high after r15-809

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ro at gcc dot gnu.org

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 115213 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/115208] [15 Regression] Memory consumption get extremely high after r15-809

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

--- Comment #3 from Rainer Orth <ro at gcc dot gnu.org> ---
An i686-pc-linux-gnu reghunt just completed, looking for the rust OOM failures
reported in PR bootstrap/115213. This patch is the culprit:

commit fae5e6a4dfcf9270cd09c2240480860b09c2c627
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Tue May 21 14:20:52 2024 -0400

    Make gori_map a shared component.

[Bug tree-optimization/115208] [15 Regression] Memory consumption get extremely high after r15-807-gfae5e6a4dfcf92

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

Sam James <sjames at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |blocker

--- Comment #4 from Sam James <sjames at gcc dot gnu.org> ---
Blocker given I can't do any more testing with this.

[Bug tree-optimization/115208] [15 Regression] Memory consumption get extremely high after r15-807-gfae5e6a4dfcf92

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slyfox at gcc dot gnu.org

--- Comment #5 from Andreas Schwab <schwab@linux-m68k.org> ---
*** Bug 115227 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/115208] [15 Regression] Memory consumption get extremely high after r15-807-gfae5e6a4dfcf92

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

--- Comment #6 from Andrew Macleod <amacleod at redhat dot com> ---
Created attachment 58287
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58287&action=edit
proposed patch

I'm testing this patch, does it resolve your problem?

I forgot to free the gori_nmap object when the companion gori object was freed.
 doh.

[Bug tree-optimization/115208] [15 Regression] Memory consumption get extremely high after r15-807-gfae5e6a4dfcf92

[slyfox at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

--- Comment #7 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
(In reply to Andrew Macleod from comment #6)
> Created attachment 58287 [details]
> proposed patch
> 
> I'm testing this patch, does it resolve your problem?
> 
> I forgot to free the gori_nmap object when the companion gori object was
> freed.  doh.

At least for me that fixed the crash when building libepoxy, doxygen and
p11-kit on i686-linux. Thank you!

[Bug tree-optimization/115208] [15 Regression] Memory consumption get extremely high after r15-807-gfae5e6a4dfcf92

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Macleod <amacleod@gcc.gnu.org>:

https://gcc.gnu.org/g:f9810728cf42ea7c3d84198aa582e53cfb2302d1

commit r15-833-gf9810728cf42ea7c3d84198aa582e53cfb2302d1
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Sat May 25 12:28:52 2024 -0400

    Delete gori_map during destruction of GORI.

    Forgot to free the gori_mpa object when a gori object is freed.

            PR tree-optimization/115208
            * value-query.cc (range_query::create_gori): Confirm gori_map is
NULL.
            (range_query::destroy_gori): Free gori_map if one was allocated.

[Bug tree-optimization/115208] [15 Regression] Memory consumption get extremely high after r15-807-gfae5e6a4dfcf92

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

--- Comment #9 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #6 from Andrew Macleod <amacleod at redhat dot com> ---
> Created attachment 58287
>   --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58287&action=edit
> proposed patch
>
> I'm testing this patch, does it resolve your problem?

It did: i386-pc-solaris2.11 and sparc-sun-solaris2.11 bootstraps
completed without issues.  Thanks.

[Bug tree-optimization/115208] [15 Regression] Memory consumption get extremely high after r15-807-gfae5e6a4dfcf92

[haochen.jiang at intel dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115208

Haochen Jiang <haochen.jiang at intel dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Haochen Jiang <haochen.jiang at intel dot com> ---
It also solved the issue for me. Thx!