[Bug tree-optimization/115221] New: [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368)

[Bug tree-optimization/115221] New: [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115221

            Bug ID: 115221
           Summary: [15 regression] ICE when building reiser4progs
                    (propagate_updated_value, at
                    gimple-range-cache.cc:1368)
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
                CC: aldyh at gcc dot gnu.org
  Target Milestone: ---

Created attachment 58282
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58282&action=edit
libcde40_static_la-cde40_repair.i

toralf reported this downstream in Gentoo at https://bugs.gentoo.org/932653.

```
# gcc -c .libs/libcde40_static_la-cde40_repair.i -O2
during GIMPLE pass: vrp
cde40_repair.c: In function ‘cde40_check_struct’:
cde40_repair.c:630:9: internal compiler error: in propagate_updated_value, at
gimple-range-cache.cc:1368
  630 | errno_t cde40_check_struct(reiser4_place_t *place, repair_hint_t *hint)
{
      |         ^~~~~~~~~~~~~~~~~~
0x55facfddf8a5 ranger_cache::propagate_updated_value(tree_node*,
basic_block_def*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/gimple-range-cache.cc:1368
0x55fad1c1816a ranger_cache::set_global_range(tree_node*, vrange const&, bool)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/gimple-range-cache.cc:1089
0x55fad1c0a615 gimple_ranger::range_of_stmt(vrange&, gimple*, tree_node*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/gimple-range.cc:344
0x55fad1c0e8c9 gimple_ranger::range_of_expr(vrange&, tree_node*, gimple*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/gimple-range.cc:112
0x55fad0852e25 iv_can_overflow_p(loop*, tree_node*, tree_node*, tree_node*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-scalar-evolution.cc:3066
0x55fad0858ac6 simple_iv_with_niters(loop*, loop*, tree_node*, affine_iv*,
tree_node**, bool)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-scalar-evolution.cc:3273
0x55fad09296a1 number_of_iterations_exit_assumptions(loop*, edge_def*,
tree_niter_desc*, gcond**, bool, basic_block_def**)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-ssa-loop-niter.cc:3198
0x55fad092d659 number_of_iterations_exit(loop*, edge_def*, tree_niter_desc*,
bool, bool, basic_block_def**)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-ssa-loop-niter.cc:3285
0x55fad092d659 estimate_numbers_of_iterations(loop*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-ssa-loop-niter.cc:4882
0x55fad0930711 loop_exits_before_overflow
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-ssa-loop-niter.cc:5286
0x55fad0931465 scev_probably_wraps_p(tree_node*, tree_node*, tree_node*,
gimple*, loop*, bool)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-ssa-loop-niter.cc:5538
0x55fad0bb3c56 get_scev_info
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/vr-values.cc:204
0x55fad0bb3c56 range_of_var_in_loop(vrange&, tree_node*, loop*, gimple*,
range_query*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/vr-values.cc:271
0x55fad1c232c8 fold_using_range::range_of_ssa_name_with_loop_info(vrange&,
tree_node*, loop*, gphi*, fur_source&)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/gimple-range-fold.cc:1267
0x55fad1c232c8 fold_using_range::range_of_phi(vrange&, gphi*, fur_source&)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/gimple-range-fold.cc:1046
0x55fad1c2b5b0 fold_using_range::fold_stmt(vrange&, gimple*, fur_source&,
tree_node*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/gimple-range-fold.cc:670
0x55fad1c2b91e fold_range(vrange&, gimple*, range_query*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/gimple-range-fold.cc:317
0x55fad1c15400 ranger_cache::range_of_expr(vrange&, tree_node*, gimple*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/gimple-range-cache.cc:1204
0x55fad1c32b87 gori_compute::compute_operand1_range(vrange&,
gimple_range_op_handler&, vrange const&, fur_source&, value_relation*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/gimple-range-gori.cc:1146
0x55fad1c348c6 gori_compute::compute_operand_range(vrange&, gimple*, vrange
const&, tree_node*, fur_source&, value_relation*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/gimple-range-gori.cc:648
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

```
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/15/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with:
/var/tmp/portage/sys-devel/gcc-15.0.9999/work/gcc-15.0.9999/configure
--host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr
--bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/15
--includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/15/include
--datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/15
--mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/15/man
--infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/15/info
--with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15
--disable-silent-rules --disable-dependency-tracking
--with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/15/python
--enable-languages=c,c++,fortran,rust --enable-obsolete --enable-secureplt
--disable-werror --with-system-zlib --enable-nls --without-included-gettext
--disable-libunwind-exceptions --enable-checking=yes,extra,rtl
--with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo Hardened
15.0.9999 p, commit bc7d81fe2f725b4043ce8b9ffb11d80032ce3f75'
--with-gcc-major-version-only --enable-libstdcxx-time --enable-lto
--disable-libstdcxx-pch --enable-shared --enable-threads=posix
--enable-__cxa_atexit --enable-clocale=gnu --enable-multilib
--with-multilib-list=m32,m64 --disable-fixed-point --enable-targets=all
--enable-libgomp --disable-libssp --disable-libada --disable-cet
--disable-systemtap --enable-valgrind-annotations --disable-vtable-verify
--disable-libvtv --with-zstd --with-isl --disable-isl-version-check
--enable-default-pie --enable-host-pie --enable-host-bind-now
--enable-default-ssp --disable-fixincludes --with-build-config=bootstrap-O3
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 15.0.0 20240523 (experimental)
66d2a76dcf625f8dbe43d3c512e9c43f588fdc25 (Gentoo Hardened 15.0.9999 p, commit
bc7d81fe2f725b4043ce8b9ffb11d80032ce3f75)
```

[Bug tree-optimization/115221] [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115221

--- Comment #1 from Sam James <sjames at gcc dot gnu.org> ---
Reducing.

[Bug tree-optimization/115221] [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115221

--- Comment #2 from Sam James <sjames at gcc dot gnu.org> ---
```
typedef unsigned uint32_t;
int cde40_t;
void aal_test_bit();
uint32_t cde40_key_pol();
long cde40_offset_check(uint32_t pos) {
  cde40_key_pol();
  if (cde40_t)
    return pos ?: 0 % 0;
}
void cde40_check_struct() {
  uint32_t i, j, to_compare;
  for (;; i++) {
    cde40_offset_check(i);
    if (to_compare == 0) {
      if (i && cde40_key_pol())
        ;
      to_compare = i;
      continue;
    }
    j = to_compare;
    for (; j < i; j++)
      aal_test_bit();
  }
}
```

but (like another recent range issue), it has the nasty division by zero again.
Let me check the original...

[Bug tree-optimization/115221] [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115221

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This one still ICEs and it is closer to the original source:
```
typedef unsigned uint32_t;
int cde40_t;
int offset;
void aal_test_bit();
uint32_t cde40_key_pol();
long cde40_offset_check(uint32_t pos) {
  cde40_key_pol();
  if (cde40_t)
    return (offset - 2) % (((pos == 3) ? 18 : 26)) != 0;
  return 0;
}
void cde40_check_struct() {
  uint32_t i, j, to_compare;
  for (;; i++) {
    cde40_offset_check(i);
    if (to_compare == 0) {
      if (i && cde40_key_pol())
        ;
      to_compare = i;
      continue;
    }
    j = to_compare;
    for (; j < i; j++)
      aal_test_bit();
  }
}
```

[Bug tree-optimization/115221] [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115221

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-05-25
           Keywords|                            |ice-on-valid-code
             Status|UNCONFIRMED                 |NEW
   Target Milestone|---                         |15.0

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
.

[Bug tree-optimization/115221] [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368)

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115221

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amacleod at redhat dot com

--- Comment #5 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Has anyone bisected this?

[Bug tree-optimization/115221] [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115221

--- Comment #6 from Sam James <sjames at gcc dot gnu.org> ---
No - do you want me to? I can, but I don't have a cache of 15 packages
available, so it might be an hour or two. Just let me know.

[Bug tree-optimization/115221] [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115221

--- Comment #7 from Sam James <sjames at gcc dot gnu.org> ---
btw, note that toralf hit this on the last snapshot -> it's
<r15-653-g8713d5eec23864, not in andrew's batch from yesterday

[Bug tree-optimization/115221] [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368) since r15-80-g0ade358cd72ffa

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115221

Sam James <sjames at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[15 regression] ICE when    |[15 regression] ICE when
                   |building reiser4progs       |building reiser4progs
                   |(propagate_updated_value,   |(propagate_updated_value,
                   |at                          |at
                   |gimple-range-cache.cc:1368) |gimple-range-cache.cc:1368)
                   |                            |since
                   |                            |r15-80-g0ade358cd72ffa

--- Comment #8 from Sam James <sjames at gcc dot gnu.org> ---
I went ahead and did it - r15-80-g0ade358cd72ffa.

[Bug tree-optimization/115221] [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368) since r15-80-g0ade358cd72ffa

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115221

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unknown                     |15.0
           Priority|P3                          |P1

[Bug tree-optimization/115221] [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368) since r15-80-g0ade358cd72ffa

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115221

--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Macleod <amacleod@gcc.gnu.org>:

https://gcc.gnu.org/g:5ada486079d6aa20c64985a20681573f4ac1c86e

commit r15-870-g5ada486079d6aa20c64985a20681573f4ac1c86e
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Mon May 27 11:00:57 2024 -0400

    Do not invoke SCEV if it will use a different range query.

    SCEV always uses the current range_query object.
    Ranger's cache uses a global value_query when propagating cache values to
    avoid re-invoking ranger during simple vavhe propagations.
    when folding a PHI value, SCEV can be invoked, and since it alwys uses
    the current range_query object, when ranger is active this causes the
    undesired re-invoking of ranger during cache propagation.

    This patch checks to see if the fold_using_range specified range_query
    object is the same as the one SCEV uses, and does not invoke SCEV if
    they do not match.

            PR tree-optimization/115221
            gcc/
            * gimple-range-fold.cc (range_of_ssa_name_with_loop_info): Do
            not invoke SCEV is range_query's do not match.
            gcc/testsuite/
            * gcc.dg/pr115221.c: New.

[Bug tree-optimization/115221] [15 regression] ICE when building reiser4progs (propagate_updated_value, at gimple-range-cache.cc:1368) since r15-80-g0ade358cd72ffa

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115221

Sam James <sjames at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Sam James <sjames at gcc dot gnu.org> ---
Fixed I think