From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 327CA388204E; Mon, 17 Jun 2024 14:26:29 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 327CA388204E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1718634389;
	bh=13I+7ZtqEcC26sB8+Ejvi5Ub+Zmh9+65tIRso8rJDqk=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=GVXxLWBDB53Zz69ZheIWbpiJET5fjXGjKrM/O9E8swizF7pNcdBM0copWVvY8ygpd
	 aKHDGAZSK50iXHIbnBukL6HkMEBzR6Zh9x7A9EKuwt2ehNhplusPqf1bm8zb/zVvG/
	 MWBNweI4k3OMYU8qTGvOGCdzop+x4tuUwR+KFByc=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/115239] [14 Regression] ICE: Segmentation fault with
 ambiguous function call in some cases (`const char*` vs `char` with `long` vs
 `unsigned`) since r14-6522
Date: Mon, 17 Jun 2024 14:26:27 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 14.1.0
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: ppalka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.2
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-115239-4-lRFFYtRVDZ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-115239-4@http.gcc.gnu.org/bugzilla/>
References: <bug-115239-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D115239

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:4df86402990e2f45e02a367f1734a22ebc041e98

commit r14-10319-g4df86402990e2f45e02a367f1734a22ebc041e98
Author: Patrick Palka <ppalka@redhat.com>
Date:   Thu Jun 13 10:02:43 2024 -0400

    c++: ICE w/ ambig and non-strictly-viable cands [PR115239]

    Here during overload resolution we have two strictly viable ambiguous
    candidates #1 and #2, and two non-strictly viable candidates #3 and #4
    which we hold on to ever since r14-6522.  These latter candidates have
    an empty second arg conversion since the first arg conversion was deemed
    bad, and this trips up joust when called on #3 and #4 which assumes all
    arg conversions are there.

    We can fix this by making joust robust to empty arg conversions, but in
    this situation we shouldn't need to compare #3 and #4 at all given that
    we have a strictly viable candidate.  To that end, this patch makes
    tourney shortcut considering non-strictly viable candidates upon
    encountering ambiguity between two strictly viable candidates (taking
    advantage of the fact that the candidates list is sorted according to
    viability via splice_viable).

            PR c++/115239

    gcc/cp/ChangeLog:

            * call.cc (tourney): Don't consider a non-strictly viable
            candidate as the champ if there was ambiguity between two
            strictly viable candidates.

    gcc/testsuite/ChangeLog:

            * g++.dg/overload/error7.C: New test.

    Reviewed-by: Jason Merrill <jason@redhat.com>
    (cherry picked from commit 7fed7e9bbc57d502e141e079a6be2706bdbd4560)=