public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug testsuite/115262] New: [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 @ 2024-05-28 15:57 seurer at gcc dot gnu.org 2024-05-29 7:36 ` [Bug testsuite/115262] " rguenth at gcc dot gnu.org ` (6 more replies) 0 siblings, 7 replies; 8+ messages in thread From: seurer at gcc dot gnu.org @ 2024-05-28 15:57 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115262 Bug ID: 115262 Summary: [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 Product: gcc Version: 15.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: testsuite Assignee: unassigned at gcc dot gnu.org Reporter: seurer at gcc dot gnu.org Target Milestone: --- g:05daf617ea22e1d818295ed2d037456937e23530, r15-831-g05daf617ea22e1 make -k check-gcc RUNTESTFLAGS="powerpc.exp=gcc.target/powerpc/pr66144-3.c" FAIL: gcc.target/powerpc/pr66144-3.c scan-assembler \\mxxsel\\M This is probably just a test case that needs assembler instruction counts updated. commit 05daf617ea22e1d818295ed2d037456937e23530 (HEAD) Author: Jeff Law <jlaw@ventanamicro.com> Date: Sat May 25 12:39:05 2024 -0600 [committed] [v2] More logical op simplifications in simplify-rtx.cc ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug testsuite/115262] [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 2024-05-28 15:57 [Bug testsuite/115262] New: [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 seurer at gcc dot gnu.org @ 2024-05-29 7:36 ` rguenth at gcc dot gnu.org 2024-06-10 22:39 ` law at gcc dot gnu.org ` (5 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: rguenth at gcc dot gnu.org @ 2024-05-29 7:36 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115262 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |15.0 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug testsuite/115262] [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 2024-05-28 15:57 [Bug testsuite/115262] New: [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 seurer at gcc dot gnu.org 2024-05-29 7:36 ` [Bug testsuite/115262] " rguenth at gcc dot gnu.org @ 2024-06-10 22:39 ` law at gcc dot gnu.org 2024-06-11 20:37 ` bergner at gcc dot gnu.org ` (4 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: law at gcc dot gnu.org @ 2024-06-10 22:39 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115262 Jeffrey A. Law <law at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Last reconfirmed| |2024-06-10 Status|UNCONFIRMED |NEW --- Comment #1 from Jeffrey A. Law <law at gcc dot gnu.org> --- It looks like the test wants to see xxsel, but after that change we get xxlor and what looks like a slight difference in register allocation. I can't really judge if the new code is better, worse is equivalent. *** good.s 2024-06-10 16:33:48.717342836 -0600 --- bad.s 2024-06-10 16:34:01.005143026 -0600 *************** test: *** 36,45 **** lxvd2x 0,8,9 vcmpequw 1,1,12 vcmpequw 0,0,13 ! xxsel 33,12,33,33 ! xxsel 32,0,32,32 ! stxvd2x 33,9,10 ! stxvd2x 32,8,9 addi 9,9,32 bdnz .L2 blr --- 36,45 ---- lxvd2x 0,8,9 vcmpequw 1,1,12 vcmpequw 0,0,13 ! xxlor 12,12,33 ! xxlor 0,0,32 ! stxvd2x 12,9,10 ! stxvd2x 0,8,9 addi 9,9,32 bdnz .L2 blr ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug testsuite/115262] [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 2024-05-28 15:57 [Bug testsuite/115262] New: [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 seurer at gcc dot gnu.org 2024-05-29 7:36 ` [Bug testsuite/115262] " rguenth at gcc dot gnu.org 2024-06-10 22:39 ` law at gcc dot gnu.org @ 2024-06-11 20:37 ` bergner at gcc dot gnu.org 2024-06-12 2:39 ` linkw at gcc dot gnu.org ` (3 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: bergner at gcc dot gnu.org @ 2024-06-11 20:37 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115262 --- Comment #2 from Peter Bergner <bergner at gcc dot gnu.org> --- (In reply to Jeffrey A. Law from comment #1) > It looks like the test wants to see xxsel, but after that change we get > xxlor and what looks like a slight difference in register allocation. I > can't really judge if the new code is better, worse is equivalent. xxsel XT,XA,XB,XC computes XT = (XA & ~XC) | (XB & XC). Using De Morgan's law given XB == XC, that seems to simplify to XT = XA | XB which is what you're producing and an xxlor (a simple logical or) is not going to be slower than a xxsel and is probably faster. I agree with Bill that this looks like an example of needing to update the expected results of the test case. I'll let Segher and/or Ke Wen comment though. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug testsuite/115262] [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 2024-05-28 15:57 [Bug testsuite/115262] New: [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 seurer at gcc dot gnu.org ` (2 preceding siblings ...) 2024-06-11 20:37 ` bergner at gcc dot gnu.org @ 2024-06-12 2:39 ` linkw at gcc dot gnu.org 2024-06-12 19:50 ` bergner at gcc dot gnu.org ` (2 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: linkw at gcc dot gnu.org @ 2024-06-12 2:39 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115262 --- Comment #3 from Kewen Lin <linkw at gcc dot gnu.org> --- (In reply to Peter Bergner from comment #2) > (In reply to Jeffrey A. Law from comment #1) > > It looks like the test wants to see xxsel, but after that change we get > > xxlor and what looks like a slight difference in register allocation. I > > can't really judge if the new code is better, worse is equivalent. > > xxsel XT,XA,XB,XC computes XT = (XA & ~XC) | (XB & XC). Using De Morgan's > law given XB == XC, that seems to simplify to XT = XA | XB which is what > you're producing and an xxlor (a simple logical or) is not going to be > slower than a xxsel and is probably faster. I agree with Bill that this > looks like an example of needing to update the expected results of the test > case. I'll let Segher and/or Ke Wen comment though. I agree they are equivalent here, from the scheduling descriptions, xxsel and xxlor are in the same unit. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug testsuite/115262] [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 2024-05-28 15:57 [Bug testsuite/115262] New: [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 seurer at gcc dot gnu.org ` (3 preceding siblings ...) 2024-06-12 2:39 ` linkw at gcc dot gnu.org @ 2024-06-12 19:50 ` bergner at gcc dot gnu.org 2024-06-13 2:08 ` cvs-commit at gcc dot gnu.org 2024-06-13 2:10 ` bergner at gcc dot gnu.org 6 siblings, 0 replies; 8+ messages in thread From: bergner at gcc dot gnu.org @ 2024-06-12 19:50 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115262 Peter Bergner <bergner at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gcc.gnu.org/piperma | |il/gcc-patches/2024-June/65 | |4397.html Status|NEW |ASSIGNED Assignee|unassigned at gcc dot gnu.org |bergner at gcc dot gnu.org ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug testsuite/115262] [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 2024-05-28 15:57 [Bug testsuite/115262] New: [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 seurer at gcc dot gnu.org ` (4 preceding siblings ...) 2024-06-12 19:50 ` bergner at gcc dot gnu.org @ 2024-06-13 2:08 ` cvs-commit at gcc dot gnu.org 2024-06-13 2:10 ` bergner at gcc dot gnu.org 6 siblings, 0 replies; 8+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2024-06-13 2:08 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115262 --- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Peter Bergner <bergner@gcc.gnu.org>: https://gcc.gnu.org/g:ae8103a3a13ac412b9ca33222594cb507ceac9f7 commit r15-1232-gae8103a3a13ac412b9ca33222594cb507ceac9f7 Author: Peter Bergner <bergner@linux.ibm.com> Date: Wed Jun 12 21:05:34 2024 -0500 rs6000: Fix pr66144-3.c test to accept multiple equivalent insns. [PR115262] Jeff's commit r15-831-g05daf617ea22e1 changed the instruction we expected for this test case into an equivalent instruction. Modify the test case so it will accept any of three instructions we could get depending on the options used. 2024-06-12 Peter Bergner <bergner@linux.ibm.com> gcc/testsuite/ PR testsuite/115262 * gcc.target/powerpc/pr66144-3.c (dg-do): Compile for all targets. (dg-options): Add -fno-unroll-loops and remove -mvsx. (scan-assembler): Change from this... (scan-assembler-times): ...to this. Tweak regex to accept multiple allowable instructions. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug testsuite/115262] [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 2024-05-28 15:57 [Bug testsuite/115262] New: [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 seurer at gcc dot gnu.org ` (5 preceding siblings ...) 2024-06-13 2:08 ` cvs-commit at gcc dot gnu.org @ 2024-06-13 2:10 ` bergner at gcc dot gnu.org 6 siblings, 0 replies; 8+ messages in thread From: bergner at gcc dot gnu.org @ 2024-06-13 2:10 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115262 Peter Bergner <bergner at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED Known to fail| |15.0 --- Comment #5 from Peter Bergner <bergner at gcc dot gnu.org> --- Fixed. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-06-13 2:10 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-05-28 15:57 [Bug testsuite/115262] New: [15 regression] gcc.target/powerpc/pr66144-3.c fails after r15-831-g05daf617ea22e1 seurer at gcc dot gnu.org 2024-05-29 7:36 ` [Bug testsuite/115262] " rguenth at gcc dot gnu.org 2024-06-10 22:39 ` law at gcc dot gnu.org 2024-06-11 20:37 ` bergner at gcc dot gnu.org 2024-06-12 2:39 ` linkw at gcc dot gnu.org 2024-06-12 19:50 ` bergner at gcc dot gnu.org 2024-06-13 2:08 ` cvs-commit at gcc dot gnu.org 2024-06-13 2:10 ` bergner at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).