public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug plugins/115288] New: File label-text.h not part of installation
@ 2024-05-30 7:12 dcb314 at hotmail dot com
2024-05-30 14:51 ` [Bug plugins/115288] [15 Regression] " pinskia at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: dcb314 at hotmail dot com @ 2024-05-30 7:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115288
Bug ID: 115288
Summary: File label-text.h not part of installation
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: plugins
Assignee: unassigned at gcc dot gnu.org
Reporter: dcb314 at hotmail dot com
Target Milestone: ---
I have just tried a linux kernel build with this morning's gcc trunk compiler
and I got this:
home/dcb40b/gcc/results.20240530.asan.ubsan/lib/gcc/x86_64-pc-linux-gnu/15.0.0/plugin/include/rich-location.h:25:10:
fatal error: label-text.h: No such file or directory
25 | #include "label-text.h"
| ^~~~~~~~~~~~~~
Doing this
$ cp /home/dcb40b/gcc/trunk.20210101/libcpp/include/label-text.h
/home/dcb40b/gcc/results.20240530.asan.ubsan/bin/../lib/gcc/x86_64-pc-linux-gnu/15.0.0/plugin/include/
$
seems to solve the problem.
It looks to me like someone forgot to add file label-text.h to some list
in the install make target.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug plugins/115288] [15 Regression] File label-text.h not part of installation
2024-05-30 7:12 [Bug plugins/115288] New: File label-text.h not part of installation dcb314 at hotmail dot com
@ 2024-05-30 14:51 ` pinskia at gcc dot gnu.org
2024-05-30 14:54 ` pinskia at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-05-30 14:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115288
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |15.0
Summary|File label-text.h not part |[15 Regression] File
|of installation |label-text.h not part of
| |installation
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug plugins/115288] [15 Regression] File label-text.h not part of installation
2024-05-30 7:12 [Bug plugins/115288] New: File label-text.h not part of installation dcb314 at hotmail dot com
2024-05-30 14:51 ` [Bug plugins/115288] [15 Regression] " pinskia at gcc dot gnu.org
@ 2024-05-30 14:54 ` pinskia at gcc dot gnu.org
2024-06-06 17:04 ` [Bug plugins/115288] [15 Regression] File label-text.h not part of installation since r15-874-g9bda2c4c81b668 cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-05-30 14:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115288
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2024-05-30
Status|UNCONFIRMED |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |pinskia at gcc dot gnu.org
Ever confirmed|0 |1
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I think this fixes the issue (which was introduced by r15-874-g9bda2c4c81b668
):
```
[apinski@xeond2 gcc]$ git diff Makefile.in
diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 66d42cc41f8..67c00a9c23f 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -1038,6 +1038,7 @@ SYSTEM_H = system.h hwint.h
$(srcdir)/../include/libiberty.h \
PREDICT_H = predict.h predict.def
CPPLIB_H = $(srcdir)/../libcpp/include/line-map.h \
$(srcdir)/../libcpp/include/rich-location.h \
+ $(srcdir)/../libcpp/include/label-text.h \
$(srcdir)/../libcpp/include/cpplib.h
CODYLIB_H = $(srcdir)/../libcody/cody.hh
INPUT_H = $(srcdir)/../libcpp/include/line-map.h input.h
```
Let me double check that and commit as obvious if it works.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug plugins/115288] [15 Regression] File label-text.h not part of installation since r15-874-g9bda2c4c81b668
2024-05-30 7:12 [Bug plugins/115288] New: File label-text.h not part of installation dcb314 at hotmail dot com
2024-05-30 14:51 ` [Bug plugins/115288] [15 Regression] " pinskia at gcc dot gnu.org
2024-05-30 14:54 ` pinskia at gcc dot gnu.org
@ 2024-06-06 17:04 ` cvs-commit at gcc dot gnu.org
2024-06-06 17:05 ` sjames at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-06-06 17:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115288
--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:
https://gcc.gnu.org/g:6e6471806d886bc052d3922d636d49aaf75d5d16
commit r15-1076-g6e6471806d886bc052d3922d636d49aaf75d5d16
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date: Thu May 30 07:59:00 2024 -0700
Plugins: Add label-text.h to CPPLIB_H so it will be installed [PR115288]
After r15-874-g9bda2c4c81b668, out of tree plugins won't compile
as the new libcpp header file label-text.h is not installed.
This adds the new header file to CPPLIB_H which is used for
the plugin headers to install.
Committed as obvious after a build and install and make sure
the new header file is installed.
gcc/ChangeLog:
PR plugins/115288
* Makefile.in (CPPLIB_H): Add label-text.h.
Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug plugins/115288] [15 Regression] File label-text.h not part of installation since r15-874-g9bda2c4c81b668
2024-05-30 7:12 [Bug plugins/115288] New: File label-text.h not part of installation dcb314 at hotmail dot com
` (2 preceding siblings ...)
2024-06-06 17:04 ` [Bug plugins/115288] [15 Regression] File label-text.h not part of installation since r15-874-g9bda2c4c81b668 cvs-commit at gcc dot gnu.org
@ 2024-06-06 17:05 ` sjames at gcc dot gnu.org
2024-06-06 17:05 ` pinskia at gcc dot gnu.org
2024-06-06 17:46 ` dmalcolm at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: sjames at gcc dot gnu.org @ 2024-06-06 17:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115288
--- Comment #3 from Sam James <sjames at gcc dot gnu.org> ---
I should've said, the obvious patch did indeed work for me.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug plugins/115288] [15 Regression] File label-text.h not part of installation since r15-874-g9bda2c4c81b668
2024-05-30 7:12 [Bug plugins/115288] New: File label-text.h not part of installation dcb314 at hotmail dot com
` (3 preceding siblings ...)
2024-06-06 17:05 ` sjames at gcc dot gnu.org
@ 2024-06-06 17:05 ` pinskia at gcc dot gnu.org
2024-06-06 17:46 ` dmalcolm at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-06-06 17:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115288
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug plugins/115288] [15 Regression] File label-text.h not part of installation since r15-874-g9bda2c4c81b668
2024-05-30 7:12 [Bug plugins/115288] New: File label-text.h not part of installation dcb314 at hotmail dot com
` (4 preceding siblings ...)
2024-06-06 17:05 ` pinskia at gcc dot gnu.org
@ 2024-06-06 17:46 ` dmalcolm at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: dmalcolm at gcc dot gnu.org @ 2024-06-06 17:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115288
--- Comment #5 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Sorry about the breakage; thanks for fixing this
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-06-06 17:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-30 7:12 [Bug plugins/115288] New: File label-text.h not part of installation dcb314 at hotmail dot com
2024-05-30 14:51 ` [Bug plugins/115288] [15 Regression] " pinskia at gcc dot gnu.org
2024-05-30 14:54 ` pinskia at gcc dot gnu.org
2024-06-06 17:04 ` [Bug plugins/115288] [15 Regression] File label-text.h not part of installation since r15-874-g9bda2c4c81b668 cvs-commit at gcc dot gnu.org
2024-06-06 17:05 ` sjames at gcc dot gnu.org
2024-06-06 17:05 ` pinskia at gcc dot gnu.org
2024-06-06 17:46 ` dmalcolm at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).