From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 7740A3858CDA; Mon, 17 Jun 2024 17:24:57 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7740A3858CDA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1718645097;
	bh=ffk3tPJL3Gu0cA6PNMjq7Zor6ZmFAMTjkfDPRGlyMtQ=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=JZGt9P5GNF7HDV4EZ9Ke+LemgoFIHBDRF49PYf/hxzGybaSYPlWdcWOS/aNDaAucr
	 arVGDug8NfeM8lDc8PLStilTjgYQsQhSsAXNrofCOoAUgHjZ+lPCWwAkMKImxR4Q0z
	 Y3/HLZPWA2IMUb9uVaUVzRHakZPbIx56MzMaTr+s=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/115290] [12/13/14/15 Regression] tree check fail in
 c_tree_printer, at c/c-objc-common.cc:330
Date: Mon, 17 Jun 2024 17:24:57 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 15.0
X-Bugzilla-Keywords: diagnostic, ice-checking, ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-115290-4-gnjvsOcain@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-115290-4@http.gcc.gnu.org/bugzilla/>
References: <bug-115290-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D115290

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:b63c7d92012f92e0517190cf263d29bbef8a06bf

commit r15-1381-gb63c7d92012f92e0517190cf263d29bbef8a06bf
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Jun 17 19:24:05 2024 +0200

    c-family: Fix -Warray-compare warning ICE [PR115290]

    The warning code uses %D to print the ARRAY_REF first operands.
    That works in the most common case where those operands are decls, but
    as can be seen on the following testcase, they can be other expressions
    with array type.
    Just changing %D to %E isn't enough, because then the diagnostics can
    suggest something like
    note: use '&(x) !=3D 0 ? (int (*)[32])&a : (int (*)[32])&b[0] =3D=3D &(=
y) !=3D 0 ?
(int (*)[32])&a : (int (*)[32])&b[0]' to compare the addresses
    which is a bad suggestion, the %E printing doesn't know that the
    warning code will want to add & before it and [0] after it.
    So, the following patch adds ()s around the operand as well, but does
    that only for non-decls, for decls keeps it as &arr[0] like before.

    2024-06-17  Jakub Jelinek  <jakub@redhat.com>

            PR c/115290
            * c-warn.cc (do_warn_array_compare): Use %E rather than %D for
            printing op0 and op1; if those operands aren't decls, also print
            parens around them.

            * c-c++-common/Warray-compare-3.c: New test.=