[Bug testsuite/115294] New: [15 regression] dg-additional-files-options change broke several testsuites

[Bug testsuite/115294] New: [15 regression] dg-additional-files-options change broke several testsuites

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115294

            Bug ID: 115294
           Summary: [15 regression] dg-additional-files-options change
                    broke several testsuites
           Product: gcc
           Version: 15.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: aoliva at gcc dot gnu.org
  Target Milestone: ---

Between 20240529 (18f477980c8597fe3dca2c2e8bd533c0c2b17aa6) and 20240530
(71899d6b4e18145f005046681208db0137c95ede),
several testsuite results were lost completely.

libatomic, libgomp, libitm, and libphobos are affected.  In each case, the
test logs show a variation of

ERROR: tcl error sourcing
/vol/gcc/src/hg/master/local/libatomic/testsuite/../../gcc/testsuite/lib/gcc-dg.exp.
wrong # args: should be "dg-additional-files-options options source dest type"
    while executing
"check_cached_effective_target $prop {
        eval [list check_no_compiler_messages_nocache $prop] $args
    }"
    (procedure "check_no_compiler_messages" line 2)
    invoked from within
"check_no_compiler_messages lto object {
       void foo (void) { }
    } "-flto""
    (procedure "check_effective_target_lto" line 11)
    invoked from within
"check_effective_target_lto"
    invoked from within
"if [info exists TORTURE_OPTIONS] {
    set DG_TORTURE_OPTIONS $TORTURE_OPTIONS
} else {
    # It is theoretically beneficial to group all of the O2/O3..."
    (file
"/vol/gcc/src/hg/master/local/libatomic/testsuite/../../gcc/testsuite/lib/gcc-dg.exp"
line 82)
    invoked from within
"source
/vol/gcc/src/hg/master/local/libatomic/testsuite/../../gcc/testsuite/lib/gcc-dg.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source
/vol/gcc/src/hg/master/local/libatomic/testsuite/../../gcc/testsuite/lib/gcc-dg.exp"
    invoked from within
"catch "uplevel #0 source $file""

I'm seeing this on both i386-pc-solaris2.11 and x86_64-pc-linux-gnu; most
likely
this happens everywhere.

[Bug testsuite/115294] [15 regression] dg-additional-files-options change broke several testsuites

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115294

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |15.0

[Bug testsuite/115294] [15 regression] dg-additional-files-options change broke several testsuites

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115294

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug testsuite/115294] [15 regression] dg-additional-files-options change broke several testsuites

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115294

--- Comment #1 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
I've identified the problem and tested a patch.  Will commit shortly.

[Bug testsuite/115294] [15 regression] dg-additional-files-options change broke several testsuites

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115294

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:

https://gcc.gnu.org/g:7e322d576eb6a87607215196bec62d3348e65b0e

commit r15-937-g7e322d576eb6a87607215196bec62d3348e65b0e
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Fri May 31 09:29:38 2024 +0200

    testsuite: Adjust several dg-additional-files-options calls [PR115294]

    A recent patch

    commit bdc264a16e327c63d133131a695a202fbbc0a6a0
    Author: Alexandre Oliva <oliva@adacore.com>
    Date:   Thu May 30 02:06:48 2024 -0300

        [testsuite] conditionalize dg-additional-sources on target and type

    added two additional args to dg-additional-files-options.
    Unfortunately, this completely broke several testsuites like

    ERROR: tcl error sourcing
/vol/gcc/src/hg/master/local/libatomic/testsuite/../../gcc/testsuite/lib/gcc-dg.exp.
    wrong # args: should be "dg-additional-files-options options source dest
type"

    since the patch forgot to adjust some of the callers.

    This patch fixes that.

    Tested on i386-pc-solaris2.11, sparc-sun-solaris2.11, and
    x86_64-pc-linux-gnu.

    2024-05-31  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

            libatomic:
            PR testsuite/115294
            * testsuite/lib/libatomic.exp (libatomic_target_compile): Pass new
            dg-additional-files-options args.

            libgomp:
            PR testsuite/115294
            * testsuite/lib/libgomp.exp (libgomp_target_compile): Pass new
            dg-additional-files-options args.

            libitm:
            PR testsuite/115294
            * testsuite/lib/libitm.exp (libitm_target_compile): Pass new
            dg-additional-files-options args.

            libphobos:
            PR testsuite/115294
            * testsuite/lib/libphobos.exp (libphobos_target_compile): Pass new
            dg-additional-files-options args.

            libvtv:
            PR testsuite/115294
            * testsuite/lib/libvtv.exp (libvtv_target_compile): Pass new
            dg-additional-files-options args.

[Bug testsuite/115294] [15 regression] dg-additional-files-options change broke several testsuites

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115294

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
           Assignee|unassigned at gcc dot gnu.org      |ro at gcc dot gnu.org
         Resolution|---                         |FIXED
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2024-May/653
                   |                            |198.html

--- Comment #3 from Rainer Orth <ro at gcc dot gnu.org> ---
Fixed for GCC 15.0.