public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/115304] gcc.dg/vect/slp-gap-1.c FAILs Date: Mon, 03 Jun 2024 12:43:36 +0000 [thread overview] Message-ID: <bug-115304-4-bvMCDurzDm@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-115304-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115304 --- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> --- For GCN the issue is that with vector(64) unsigned short we fail the permute (but we have { target vect64 } for this reason), but we then re-try with the same mode but with SLP disabled and that succeeds. The best strathegy for GCN would be to gather V4QImode aka SImode into the V64QImode (or V16SImode) vector. For pix2 we have a gap of 28 elements, doing consecutive loads isn't a good strategy here. On x86 we can use a small vector and use half of it (gathers would be slow). On sparc we start with V8QImode which is great but then sparc doesn't seem able to build a V8QImode vector from two V4QImode vectors or have V2SImode and build from two SImode values (and load SImode from pix1/pix2, that possibly due to alignment). I do see a vec_initv2sisi though. Ah, so we verify we can do the load using a permutation, permute two V8QImode 'a' and 'b' to get you a { a_low, b_low } V8QImode vector. The other part is eliding of the gap that will end up loading half of the vector but then pad it out as { a_low, 0 } but then still invoke this unsupported permutation to get { a_low, b_low }. So in this case requiring vect_perm would fix this though there is sparc_vectorize_vec_perm_const and vec_perm<> guarded with VIS2, with -mvis2 we get past this failure point and run into missed: not vectorized: relevant stmt not supported: _35 = (unsigned short) _34; So there's no vec_upack_{hi,lo}_v4hi. vect_unpack guards this. Maybe I should move the test to be x86 specific. I'll add the two dg-effective targets to fix the solaris fallout for now.
next prev parent reply other threads:[~2024-06-03 12:43 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-05-31 8:45 [Bug tree-optimization/115304] New: " ro at gcc dot gnu.org 2024-05-31 8:46 ` [Bug tree-optimization/115304] " ro at gcc dot gnu.org 2024-05-31 8:46 ` ro at gcc dot gnu.org 2024-05-31 12:26 ` rguenth at gcc dot gnu.org 2024-06-03 9:18 ` ro at CeBiTec dot Uni-Bielefeld.DE 2024-06-03 10:10 ` tschwinge at gcc dot gnu.org 2024-06-03 10:10 ` tschwinge at gcc dot gnu.org 2024-06-03 10:13 ` tschwinge at gcc dot gnu.org 2024-06-03 12:43 ` rguenth at gcc dot gnu.org [this message] 2024-06-03 12:46 ` cvs-commit at gcc dot gnu.org 2024-06-03 12:47 ` rguenth at gcc dot gnu.org 2024-06-03 13:33 ` ams at gcc dot gnu.org 2024-06-03 13:51 ` rguenther at suse dot de 2024-06-03 14:11 ` ams at gcc dot gnu.org 2024-06-20 5:15 ` pinskia at gcc dot gnu.org 2024-06-20 6:45 ` rguenther at suse dot de
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-115304-4-bvMCDurzDm@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).