public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/115342] [14/15 Regression] AArch64: Function multiversioning initialization incorrect
Date: Fri, 21 Jun 2024 16:33:36 +0000	[thread overview]
Message-ID: <bug-115342-4-bmuGASAmrO@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-115342-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115342

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Wilco Dijkstra
<wilco@gcc.gnu.org>:

https://gcc.gnu.org/g:9421f02916676d27e24fcda918f85e359329ac69

commit r14-10338-g9421f02916676d27e24fcda918f85e359329ac69
Author: Wilco Dijkstra <wilco.dijkstra@arm.com>
Date:   Wed Jun 5 14:04:33 2024 +0100

    AArch64: Fix cpu features initialization [PR115342]

    The CPU features initialization code uses CPUID registers (rather than
    HWCAP).  The equality comparisons it uses are incorrect: for example
FEAT_SVE
    is not set if SVE2 is available.  Using HWCAPs for these is both simpler
and
    correct.  The initialization must also be done atomically to avoid multiple
    threads causing corruption due to non-atomic RMW accesses to the global.

    libgcc:
            PR target/115342
            * config/aarch64/cpuinfo.c (__init_cpu_features_constructor):
            Use HWCAP where possible.  Use atomic write for initialization.
            Fix FEAT_PREDRES comparison.
            (__init_cpu_features_resolver): Use atomic load for correct
            initialization.
            (__init_cpu_features): Likewise.
    (cherry picked from commit d7cbcfe7c33645eaf95f175f19884d443817857b)

  parent reply	other threads:[~2024-06-21 16:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04  9:11 [Bug target/115342] New: " wilco at gcc dot gnu.org
2024-06-05  6:42 ` [Bug target/115342] " rguenth at gcc dot gnu.org
2024-06-05 13:21 ` cvs-commit at gcc dot gnu.org
2024-06-20  4:47 ` ramana at gcc dot gnu.org
2024-06-20 10:38 ` wilco at gcc dot gnu.org
2024-06-21 16:33 ` cvs-commit at gcc dot gnu.org [this message]
2024-06-21 16:36 ` wilco at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-115342-4-bmuGASAmrO@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).