public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/115378] [14/15 Regression] ICE with lambda function as a default template argument with variadic templates in some cases
Date: Fri, 07 Jun 2024 16:14:02 +0000	[thread overview]
Message-ID: <bug-115378-4-jZ6KOzBUnO@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-115378-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115378

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:5c761395402a730535983a5e49ef1775561ebc61

commit r15-1103-g5c761395402a730535983a5e49ef1775561ebc61
Author: Patrick Palka <ppalka@redhat.com>
Date:   Fri Jun 7 12:12:30 2024 -0400

    c++: lambda in pack expansion [PR115378]

    Here find_parameter_packs_r is incorrectly treating the 'auto' return
    type of a lambda as a parameter pack due to Concepts-TS specific logic
    added in r6-4517, leading to confusion later when expanding the pattern.

    Since we intend on removing Concepts TS support soon anyway, this patch
    fixes this by restricting the problematic logic with flag_concepts_ts.
    Doing so revealed that add_capture was relying on this logic to set
    TEMPLATE_TYPE_PARAMETER_PACK for the 'auto' type of an pack expansion
    init-capture, which we now need to do explicitly.

            PR c++/115378

    gcc/cp/ChangeLog:

            * lambda.cc (lambda_capture_field_type): Set
            TEMPLATE_TYPE_PARAMETER_PACK on the auto type of an init-capture
            pack expansion.
            * pt.cc (find_parameter_packs_r) <case TEMPLATE_TYPE_PARM>:
            Restrict TEMPLATE_TYPE_PARAMETER_PACK promotion with
            flag_concepts_ts.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp1y/decltype-auto-103497.C: Adjust expected diagnostic.
            * g++.dg/template/pr95672.C: Likewise.
            * g++.dg/cpp2a/lambda-targ5.C: New test.

    Reviewed-by: Jason Merrill <jason@redhat.com>

  parent reply	other threads:[~2024-06-07 16:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06 22:03 [Bug c++/115378] New: [ice-on-valid] code using friend injection is crashing gcc since 14 eric.niebler at gmail dot com
2024-06-06 22:13 ` [Bug c++/115378] " pinskia at gcc dot gnu.org
2024-06-06 22:14 ` pinskia at gcc dot gnu.org
2024-06-06 22:34 ` pinskia at gcc dot gnu.org
2024-06-06 22:40 ` pinskia at gcc dot gnu.org
2024-06-06 22:42 ` [Bug c++/115378] [14/15 Regression] ICE with lambda function as a default template argument with variadic templates in some cases pinskia at gcc dot gnu.org
2024-06-07 13:49 ` ppalka at gcc dot gnu.org
2024-06-07 16:14 ` cvs-commit at gcc dot gnu.org [this message]
2024-06-10 14:16 ` cvs-commit at gcc dot gnu.org
2024-06-10 14:16 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-115378-4-jZ6KOzBUnO@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).