public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "bergner at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/115389] Invalid ROP hashst offset is emitted when using -mabi=no-altivec
Date: Wed, 12 Jun 2024 03:16:14 +0000 [thread overview]
Message-ID: <bug-115389-4-fXyoOjlUQe@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-115389-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115389
--- Comment #4 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Segher Boessenkool from comment #2)
> So, what value do we output? And why?
The invalid offset is zero, so: hashst r0,0(r1)
As the assembler mentions, the range of valid offsets is [-512,-8] and the
offset must be a multiple of 8.
The "bug" is that we initialize rop_hash_save_offset to zero very early, before
any option processing. Later, we compute the actual offset, but only in the
case where Altivec is enabled (TARGET_ALTIVEC_ABI is true). If Altivec is
disabled as in this test case, we end up using rop_hash_save_offset's invalid
initial zero value.
next prev parent reply other threads:[~2024-06-12 3:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 21:34 [Bug target/115389] New: " bergner at gcc dot gnu.org
2024-06-07 21:36 ` [Bug target/115389] " bergner at gcc dot gnu.org
2024-06-11 22:54 ` segher at gcc dot gnu.org
2024-06-11 22:55 ` segher at gcc dot gnu.org
2024-06-12 3:16 ` bergner at gcc dot gnu.org [this message]
2024-06-17 13:14 ` cvs-commit at gcc dot gnu.org
2024-06-17 13:15 ` bergner at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-115389-4-fXyoOjlUQe@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).