public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "marcuscalhounlopez at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug bootstrap/115416] [13/14/15 regression] Setting --includedir to a nonexistent directory causes a build error since r13-5490-g59e4c98173a79f Date: Mon, 10 Jun 2024 17:32:33 +0000 [thread overview] Message-ID: <bug-115416-4-IoRAaZ6voF@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-115416-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115416 --- Comment #5 from Marcus Calhoun-Lopez <marcuscalhounlopez at gmail dot com> --- (In reply to YunQiang Su from comment #3) > Since it doesn't exist, why use --includedir with it? /opt/local/include/gcc is where the header files will be installed after the build, so there is no reason for it to exist before the build. > Anyway, so, maybe we should detect the existence of this dir. > Can you have a try of this patch? > > --- a/gcc/Makefile.in > +++ b/gcc/Makefile.in > @@ -560,10 +560,11 @@ LINKER_PLUGIN_API_H = $(srcdir)/../include/plugin-api.h > # Default native SYSTEM_HEADER_DIR, to be overridden by targets. > NATIVE_SYSTEM_HEADER_DIR = @NATIVE_SYSTEM_HEADER_DIR@ > # Default cross SYSTEM_HEADER_DIR, to be overridden by targets. > -ifeq (@includedir@,$(prefix)/include) > - CROSS_SYSTEM_HEADER_DIR = @CROSS_SYSTEM_HEADER_DIR@ > -else > - CROSS_SYSTEM_HEADER_DIR = @includedir@ > +CROSS_SYSTEM_HEADER_DIR = @CROSS_SYSTEM_HEADER_DIR@ > +ifneq (@includedir@,$(prefix)/include) > + ifneq (,$(wildcard @includedir@)) > + CROSS_SYSTEM_HEADER_DIR = @includedir@ > + endif > endif Yes, this seems to work. Thank you very much.
next prev parent reply other threads:[~2024-06-10 17:32 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-06-10 15:07 [Bug bootstrap/115416] New: Setting --includedir to a nonexistent directory causes a build error marcuscalhounlopez at gmail dot com 2024-06-10 15:36 ` [Bug bootstrap/115416] " sjames at gcc dot gnu.org 2024-06-10 15:39 ` [Bug bootstrap/115416] [13/14/15 regression] Setting --includedir to a nonexistent directory causes a build error since r13-5490-g59e4c98173a79f sjames at gcc dot gnu.org 2024-06-10 16:09 ` syq at gcc dot gnu.org 2024-06-10 17:01 ` syq at gcc dot gnu.org 2024-06-10 17:27 ` marcuscalhounlopez at gmail dot com 2024-06-10 17:32 ` marcuscalhounlopez at gmail dot com [this message] 2024-06-10 17:41 ` syq at gcc dot gnu.org 2024-06-11 9:10 ` syq at gcc dot gnu.org 2024-06-11 9:35 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-115416-4-IoRAaZ6voF@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).