[Bug bootstrap/115465] New: [15 Regression] aarch64-early-ra.cc:3449:23: error: ‘class pretty_printer’ has no member named ‘buffer’

[Bug bootstrap/115465] New: [15 Regression] aarch64-early-ra.cc:3449:23: error: ‘class pretty_printer’ has no member named ‘buffer’

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115465

            Bug ID: 115465
           Summary: [15 Regression] aarch64-early-ra.cc:3449:23: error:
                    ‘class pretty_printer’ has no member named ‘buffer’
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dmalcolm at gcc dot gnu.org
  Target Milestone: ---
            Target: aarch64-*-*

Looks like I broke the build on aarch64 with r15-1209-gc5e3be456888aa.

  https://builder.sourceware.org/buildbot/#/builders/266/builds/3613

../../gcc/gcc/config/aarch64/aarch64-early-ra.cc: In member function ‘void
{anonymous}::early_ra::process_block(basic_block, bool)’:
../../gcc/gcc/config/aarch64/aarch64-early-ra.cc:3449:23: error: ‘class
pretty_printer’ has no member named ‘buffer’; did you mean ‘output_buffer*
pretty_printer::m_buffer’? (not accessible from this context)
 3449 |           rtl_slim_pp.buffer->stream = dump_file;
      |                       ^~~~~~
In file included from ../../gcc/gcc/rtl-ssa.h:39,
                 from ../../gcc/gcc/config/aarch64/aarch64-early-ra.cc:49:
../../gcc/gcc/pretty-print.h:327:18: note: declared private here
  327 |   output_buffer *m_buffer;

Sorry; am working on a fix.

[Bug bootstrap/115465] [15 Regression] aarch64-early-ra.cc:3449:23: error: ‘class pretty_printer’ has no member named ‘buffer’

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115465

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |dmalcolm at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-06-12

[Bug bootstrap/115465] [15 Regression] aarch64-early-ra.cc:3449:23: error: ‘class pretty_printer’ has no member named ‘buffer’

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115465

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu.org
           Keywords|                            |build
   Target Milestone|---                         |15.0

[Bug bootstrap/115465] [15 Regression] aarch64-early-ra.cc:3449:23: error: ‘class pretty_printer’ has no member named ‘buffer’

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115465

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
          pretty_printer rtl_slim_pp;
          rtl_slim_pp.buffer->stream = dump_file;
          print_insn (&rtl_slim_pp, insn, 1);
          pp_flush (&rtl_slim_pp);
          fprintf (dump_file, "\n");


There seems to be a better way of implement this than the above too.

Maybe change dump_insn_slim to take an bool argument that defaults to true and
then if it was false use print_insn instead of print_insn_with_notes.

[Bug bootstrap/115465] [15 Regression] aarch64-early-ra.cc:3449:23: error: ‘class pretty_printer’ has no member named ‘buffer’

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115465

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:e35f4eab68773b08324f9784ca69f8ace3c657cc

commit r15-1220-ge35f4eab68773b08324f9784ca69f8ace3c657cc
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Wed Jun 12 14:24:47 2024 -0400

    pretty_printer: unbreak build on aarch64 [PR115465]

    I missed this target-specific usage of pretty_printer::buffer when
    making the fields private in r15-1209-gc5e3be456888aa; sorry.

    gcc/ChangeLog:
            PR bootstrap/115465
            * config/aarch64/aarch64-early-ra.cc (early_ra::process_block):
            Update for fields of pretty_printer becoming private in
            r15-1209-gc5e3be456888aa.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

[Bug bootstrap/115465] [15 Regression] aarch64-early-ra.cc:3449:23: error: ‘class pretty_printer’ has no member named ‘buffer’

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115465

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Build breakage should be fixed by the above patch.

[Bug bootstrap/115465] [15 Regression] aarch64-early-ra.cc:3449:23: error: ‘class pretty_printer’ has no member named ‘buffer’

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115465

--- Comment #4 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
(In reply to David Malcolm from comment #3)
> Build breakage should be fixed by the above patch.

Indeed, https://builder.sourceware.org/buildbot/#/builders/266/builds/3620
succeeded.