[Bug libstdc++/115482] New: print.cc fails with avrlibc

[Bug libstdc++/115482] New: print.cc fails with avrlibc

[dv at vollmann dot ch]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115482

            Bug ID: 115482
           Summary: print.cc fails with avrlibc
           Product: gcc
           Version: 15.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dv at vollmann dot ch
  Target Milestone: ---

Created attachment 58421
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58421&action=edit
A workaround that worked for me

avrlibc has an incomplete unistd.h that doesn't have isatty.
So building libstdc++ fails when compiling c++23/print.cc.
As a workaround I added a check for AVR.

With this workaround (and the patch from 115481) libstdc++ build for me with
AVR-LIBC 2.2.0:

../../src/gcc/configure \
    --prefix=/opt/avr \
    --target=avr \
    --enable-languages=c,c++ \
    --with-dwarf2 \
    --enable-multilib \
    --enable-libstdcxx \
    --disable-decimal-float \
    --disable-libffi \
    --disable-libgomp \
    --disable-libmudflap \
    --disable-libquadmath \
    --disable-libssp \
    --disable-libstdcxx-pch \
    --disable-nls \
    --without-included-gettext \
    --disable-libstdcxx-verbose \
    --disable-shared \
    --disable-threads \
    --disable-tls \
    --disable-plugin \
    --with-system-zlib \
    --with-headers=yes \
    --with-gnu-as \
    --with-gnu-ld \
    --with-avrlibc

[Bug libstdc++/115482] print.cc fails with avrlibc

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115482

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-06-14
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The change seems reasonable, but I should probably just add a proper check for
isatty, instead of assuming that it will exist in <unistd.h> if we have that
header.

[Bug libstdc++/115482] [14/15 Regression] print.cc fails with avrlibc

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115482

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build
   Target Milestone|---                         |14.2
            Summary|print.cc fails with avrlibc |[14/15 Regression] print.cc
                   |                            |fails with avrlibc

[Bug libstdc++/115482] [14/15 Regression] print.cc fails with avrlibc

[dv at vollmann dot ch]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115482

--- Comment #2 from dv at vollmann dot ch ---
On 6/14/24 11:54, redi at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115482
> 
> Jonathan Wakely <redi at gcc dot gnu.org> changed:
> 
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>     Last reconfirmed|                            |2024-06-14
>               Status|UNCONFIRMED                 |NEW
>       Ever confirmed|0                           |1
> 
> --- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
> The change seems reasonable, but I should probably just add a proper check for
> isatty, instead of assuming that it will exist in <unistd.h> if we have that
> header.

I agree, my diff is a workaround, I don't consider it a proper fix.

_GLIBCPP_HAVE_ISATTY was removed in 2003...

   Detlef

[Bug libstdc++/115482] [14/15 Regression] print.cc fails with avrlibc

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115482

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org