public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/115517] Fix x86 regressions after dropping uses of vcond{,u,eq}_optab
Date: Mon, 01 Jul 2024 05:21:07 +0000	[thread overview]
Message-ID: <bug-115517-4-MhjqwBIOou@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-115517-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115517

--- Comment #11 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:

https://gcc.gnu.org/g:e94e6ee495d95f29355bbc017214228a5e367638

commit r15-1740-ge94e6ee495d95f29355bbc017214228a5e367638
Author: liuhongt <hongtao.liu@intel.com>
Date:   Wed Jun 19 16:05:58 2024 +0800

    Adjust testcase for the regressed testcases after obsolete of vcond{,u,eq}.

    > Richard suggests that we implement the "obvious" transforms like
    > inversion in the middle-end but if for example unsigned compares
    > are not supported the us_minus + eq + negative trick isn't on
    > that list.
    >
    > The main reason to restrict vec_cmp would be to avoid
    > a <= b ? c : d going with an unsupported vec_cmp but instead
    > do a > b ? d : c - the alternative is trying to fix this
    > on the RTL side via combine.  I understand the non-native

    Yes, I have a patch which can fix most regressions via pattern match
    in combine.
    Still there is a situation that is difficult to deal with, mainly the
    optimization w/o sse4.1 . Because pblendvb/blendvps/blendvpd only
    exists under sse4.1, w/o sse4.1, it takes 3
    instructions (pand,pandn,por) to simulate the vcond_mask, and the
    combine matches up to 4 instructions, which makes it currently
    impossible to use the combine to recover those optimizations in the
    vcond{,u,eq}.i.e min/max.

    In the case of sse 4.1 and above, there is basically no regression anymore.

    the regression testcases w/o sse4.1

    FAIL: g++.target/i386/pr100637-1b.C  -std=gnu++14  scan-assembler-times
pcmpeqb 2
    FAIL: g++.target/i386/pr100637-1b.C  -std=gnu++17  scan-assembler-times
pcmpeqb 2
    FAIL: g++.target/i386/pr100637-1b.C  -std=gnu++20  scan-assembler-times
pcmpeqb 2
    FAIL: g++.target/i386/pr100637-1b.C  -std=gnu++98  scan-assembler-times
pcmpeqb 2
    FAIL: g++.target/i386/pr100637-1w.C  -std=gnu++14  scan-assembler-times
pcmpeqw 2
    FAIL: g++.target/i386/pr100637-1w.C  -std=gnu++17  scan-assembler-times
pcmpeqw 2
    FAIL: g++.target/i386/pr100637-1w.C  -std=gnu++20  scan-assembler-times
pcmpeqw 2
    FAIL: g++.target/i386/pr100637-1w.C  -std=gnu++98  scan-assembler-times
pcmpeqw 2
    FAIL: g++.target/i386/pr103861-1.C  -std=gnu++14  scan-assembler-times
pcmpeqb 2
    FAIL: g++.target/i386/pr103861-1.C  -std=gnu++17  scan-assembler-times
pcmpeqb 2
    FAIL: g++.target/i386/pr103861-1.C  -std=gnu++20  scan-assembler-times
pcmpeqb 2
    FAIL: g++.target/i386/pr103861-1.C  -std=gnu++98  scan-assembler-times
pcmpeqb 2
    FAIL: gcc.target/i386/pr88540.c scan-assembler minpd

    gcc/testsuite/ChangeLog:

            PR target/115517
            * g++.target/i386/pr100637-1b.C: Add xfail and -mno-sse4.1.
            * g++.target/i386/pr100637-1w.C: Ditto.
            * g++.target/i386/pr103861-1.C: Ditto.
            * gcc.target/i386/pr88540.c: Ditto.
            * gcc.target/i386/pr103941-2.c: Add -mno-avx512f.
            * g++.target/i386/sse4_1-pr100637-1b.C: New test.
            * g++.target/i386/sse4_1-pr100637-1w.C: New test.
            * g++.target/i386/sse4_1-pr103861-1.C: New test.
            * gcc.target/i386/sse4_1-pr88540.c: New test.

  parent reply	other threads:[~2024-07-01  5:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17  8:05 [Bug target/115517] New: Fix regression " liuhongt at gcc dot gnu.org
2024-06-18  6:20 ` [Bug target/115517] Fix x86 regressions " rguenth at gcc dot gnu.org
2024-06-18  8:39 ` liuhongt at gcc dot gnu.org
2024-06-18 10:49 ` rguenther at suse dot de
2024-06-18 11:08 ` liuhongt at gcc dot gnu.org
2024-06-18 11:17 ` rguenther at suse dot de
2024-06-18 11:29 ` liuhongt at gcc dot gnu.org
2024-07-01  5:20 ` cvs-commit at gcc dot gnu.org
2024-07-01  5:20 ` cvs-commit at gcc dot gnu.org
2024-07-01  5:20 ` cvs-commit at gcc dot gnu.org
2024-07-01  5:21 ` cvs-commit at gcc dot gnu.org
2024-07-01  5:21 ` cvs-commit at gcc dot gnu.org [this message]
2024-07-01  5:21 ` cvs-commit at gcc dot gnu.org
2024-07-01  5:21 ` cvs-commit at gcc dot gnu.org
2024-07-01  5:26 ` liuhongt at gcc dot gnu.org
2024-07-01  5:27 ` liuhongt at gcc dot gnu.org
2024-07-01  6:45 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-115517-4-MhjqwBIOou@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).