public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/115537] [15 Regression] vectorizable_reduction ICEs after g:d66b820f392aa9a7c34d3cddaf3d7c73bf23f82d
Date: Tue, 18 Jun 2024 12:00:20 +0000	[thread overview]
Message-ID: <bug-115537-4-tdBMrR58hC@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-115537-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115537

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
So w/o SLP we reject this with

  if ((double_reduc || reduction_type != TREE_CODE_REDUCTION)
      && ncopies > 1)
    {         
      if (dump_enabled_p ())
        dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location,
                         "multiple types in double reduction or condition "
                         "reduction or fold-left reduction.\n");
      return false;

reduction_type is EXTRACT_LAST_REDUCTION here.  For SLP we only disallow

  if ((reduction_type == COND_REDUCTION
       || reduction_type == INTEGER_INDUC_COND_REDUCTION
       || reduction_type == CONST_COND_REDUCTION)
      && slp_node
      && SLP_TREE_NUMBER_OF_VEC_STMTS (slp_node) > 1)
    {                            
      if (dump_enabled_p ())
        dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location,
                         "multiple types in condition reduction reduction.\n");
      return false;
    }

I've recently fixed a fold-left reduction case with multiple types
which we handle just fine.  I have a patch amending the above condition
(EXTRACT_LAST is an optimized COND_REDUCTION).

  parent reply	other threads:[~2024-06-18 12:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 11:12 [Bug tree-optimization/115537] New: " tnfchris at gcc dot gnu.org
2024-06-18 11:46 ` [Bug tree-optimization/115537] " rguenth at gcc dot gnu.org
2024-06-18 12:00 ` rguenth at gcc dot gnu.org [this message]
2024-06-18 13:28 ` cvs-commit at gcc dot gnu.org
2024-06-18 13:28 ` rguenth at gcc dot gnu.org
2024-06-18 14:11 ` tnfchris at gcc dot gnu.org
2024-06-18 15:29 ` rguenther at suse dot de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-115537-4-tdBMrR58hC@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).