[Bug modula2/115540] New: "gcc/m2/mc-boot-ch/Gtermios.cc:292:20: error: return-statement with a value, in function returning 'void' [-fpermissive]" when HAVE_CFMAKERAW is defined

[Bug modula2/115540] New: "gcc/m2/mc-boot-ch/Gtermios.cc:292:20: error: return-statement with a value, in function returning 'void' [-fpermissive]" when HAVE_CFMAKERAW is defined

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115540

            Bug ID: 115540
           Summary: "gcc/m2/mc-boot-ch/Gtermios.cc:292:20: error:
                    return-statement with a value, in function returning
                    'void' [-fpermissive]" when HAVE_CFMAKERAW is defined
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: dmalcolm at gcc dot gnu.org
  Target Milestone: ---

I got a bootstrap failure on cfarm119 with:

   286  /* cfmakeraw - sets the terminal to raw mode.  */
   287  
   288  void
   289  EXPORT (cfmakeraw) (struct termios *t)
   290  {
   291  #if defined(HAVE_CFMAKERAW)
   292    return cfmakeraw (t);
   293  #endif
   294  }

../../src/gcc/m2/mc-boot-ch/Gtermios.cc: In function 'void
termios_cfmakeraw(termios*)':
../../src/gcc/m2/mc-boot-ch/Gtermios.cc:292:20: error: return-statement with a
value, in function returning 'void' [-fpermissive]
  292 |   return cfmakeraw (t);
      |          ~~~~~~~~~~^~~

Seems to have been present since 1eee94d351774cdc2efc8ee508b82d065184c6ee.

[Bug modula2/115540] "gcc/m2/mc-boot-ch/Gtermios.cc:292:20: error: return-statement with a value, in function returning 'void' [-fpermissive]" when HAVE_CFMAKERAW is defined

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115540

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-06-25

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Many thanks for the bug report - confirmed.

[Bug modula2/115540] "gcc/m2/mc-boot-ch/Gtermios.cc:292:20: error: return-statement with a value, in function returning 'void' [-fpermissive]" when HAVE_CFMAKERAW is defined

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115540

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 58514
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58514&action=edit
Proposed fix

Here is a proposed patch - which is currently being bootstrap tested.

[Bug modula2/115540] "gcc/m2/mc-boot-ch/Gtermios.cc:292:20: error: return-statement with a value, in function returning 'void' [-fpermissive]" when HAVE_CFMAKERAW is defined

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115540

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:d16355c72c7f7b54ecf06371d14d7ad309ea4c34

commit r15-1623-gd16355c72c7f7b54ecf06371d14d7ad309ea4c34
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Tue Jun 25 21:37:44 2024 +0100

    PR modula2/115540 gcc/m2/mc-boot-ch/Gtermios.cc error return-statement with
a value

    This patch fixes three occurrences of cfmakeraw use in the hand built
    m2 support libraries which incorrectly attempt to return a void
    result.

    gcc/m2/ChangeLog:

            PR modula2/115540
            * gm2-libs-ch/termios.c (cfmakeraw): Remove return.
            * mc-boot-ch/Gtermios.cc (cfmakeraw): Remove return.
            * pge-boot/Gtermios.cc (cfmakeraw): Remove return.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/115540] "gcc/m2/mc-boot-ch/Gtermios.cc:292:20: error: return-statement with a value, in function returning 'void' [-fpermissive]" when HAVE_CFMAKERAW is defined

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115540

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing now that the patch has been applied.