[Bug libstdc++/115585] New: --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[Bug libstdc++/115585] New: --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

            Bug ID: 115585
           Summary: --disable-libstdcxx-verbose causes undefined symbol:
                    _ZSt21__glibcxx_assert_failPKciS0_S0_, version
                    GLIBCXX_3.4.30
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: unlvsur at live dot com
  Target Milestone: ---

https://github.com/gcc-mirror/gcc/blob/ccbcde5ec0e481e1ea775649d59691b6f5fcc5a1/libstdc%2B%2B-v3/src/c%2B%2B11/assert_fail.cc#L28C8-L28C31

i think we should provide a dummy implementation of this function when
_GLIBCXX_VERBOSE_ASSERT is disabled by just calling abort, or it breaks abi.

[Bug libstdc++/115585] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

--- Comment #1 from cqwrteur <unlvsur at live dot com> ---
cqwrteur@otsiningo:~/toolchains_build/build/native/mold$ cmake -GNinja
../../../mold -DCMAKE_BUILD_TYPE=Release
-DCMAKE_INTERPROCEDURAL_OPTIMIZATION=On -DCMAKE_C_COMPILER=clang
-DCMAKE_CXX_COMPILER=clang++ -DCMAKE_ASM_COMPILER=clang
-DCMAKE_INSTALL_PREFIX=$HOME/toolchains/x86_64-pc-linux-gnu/x86_64-pc-linux-gnu
-DCMAKE_C_FLAGS="--gcc-toolchain=$HOME/toolchains/x86_64-pc-linux-gnu/x86_64-pc-linux-gnu
-fuse-ld=lld"
-DCMAKE_CXX_FLAGS="$HOME/toolchains/x86_64-pc-linux-gnu/x86_64-pc-linux-gnu
-fuse-ld=lld"
cmake: symbol lookup error: /usr/lib/libcppdap.so: undefined symbol:
_ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

The problem is the archlinux provides libcppdap which compiles with verbose one
but i disable the verbose build.

[Bug libstdc++/115585] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

--- Comment #2 from cqwrteur <unlvsur at live dot com> ---
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655427.html

patch is here

[Bug libstdc++/115585] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
https://gcc.gnu.org/onlinedocs/gcc-14.1.0/libstdc++/manual/manual/configure.html


--disable-libstdcxx-verbose
By default, the library is configured to write descriptive messages to standard
error for certain events such as calling a pure virtual function or the
invocation of the standard terminate handler. Those messages cause the library
to depend on the demangler and standard I/O facilities, which might be
undesirable in a low-memory environment or when standard error is not
available. This option disables those messages. This option does not change the
library ABI.

Either the documentation is incorrect or we should provide an empty one.

[Bug libstdc++/115585] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Hmm, why was libcppdap.so compiled with _GLIBCXX_DEBUG turned on in the first
place?

[Bug libstdc++/115585] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

--- Comment #5 from cqwrteur <unlvsur at live dot com> ---
(In reply to Andrew Pinski from comment #4)
> Hmm, why was libcppdap.so compiled with _GLIBCXX_DEBUG turned on in the
> first place?

i don't know. That was a packaging thing from arch. I just got the raw binary
from it.

[Bug libstdc++/115585] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

--- Comment #6 from cqwrteur <unlvsur at live dot com> ---
(In reply to Andrew Pinski from comment #3)
> https://gcc.gnu.org/onlinedocs/gcc-14.1.0/libstdc++/manual/manual/configure.
> html
> 
> 
> --disable-libstdcxx-verbose
> By default, the library is configured to write descriptive messages to
> standard error for certain events such as calling a pure virtual function or
> the invocation of the standard terminate handler. Those messages cause the
> library to depend on the demangler and standard I/O facilities, which might
> be undesirable in a low-memory environment or when standard error is not
> available. This option disables those messages. This option does not change
> the library ABI.
> 
> Either the documentation is incorrect or we should provide an empty one.

i have provided an empty implementation that fixes the issue. Please review my
patch and merge it

[Bug libstdc++/115585] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

--- Comment #7 from cqwrteur <unlvsur at live dot com> ---
The patch has passed the CI. It is time to review and merge my patch. Thank
you.

https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655430.html
https://patchwork.sourceware.org/project/gcc/patch/SA1PR11MB713044B81EAB485B95D8FB7FB2CA2@SA1PR11MB7130.namprd11.prod.outlook.com/

[Bug libstdc++/115585] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to cqwrteur from comment #7)
> The patch has passed the CI. It is time to review and merge my patch. Thank
> you.

Before we can review it, can you make sure you follow
https://gcc.gnu.org/contribute.html ?
You are missing a changelog for one.
Second since you are not using your real name, do you have a copyright
assignment on file with the FSF? If not please resubmit with your real name and
add a signed-off by. Or put in place a copyright assignment.

[Bug libstdc++/115585] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

--- Comment #9 from cqwrteur <unlvsur at live dot com> ---
(In reply to Andrew Pinski from comment #8)
> (In reply to cqwrteur from comment #7)
> > The patch has passed the CI. It is time to review and merge my patch. Thank
> > you.
> 
> Before we can review it, can you make sure you follow
> https://gcc.gnu.org/contribute.html ?
> You are missing a changelog for one.
> Second since you are not using your real name, do you have a copyright
> assignment on file with the FSF? If not please resubmit with your real name
> and add a signed-off by. Or put in place a copyright assignment.

https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655461.html

Is this ok now?

[Bug libstdc++/115585] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

--- Comment #10 from cqwrteur <unlvsur at live dot com> ---
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655462.html

[Bug libstdc++/115585] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

--- Comment #11 from cqwrteur <unlvsur at live dot com> ---
Hi? Could anyone help review my patch and merge it? Ty

https://patchwork.sourceware.org/project/gcc/patch/SA1PR11MB71305D480B48400426C253D9B2CA2@SA1PR11MB7130.namprd11.prod.outlook.com/

[Bug libstdc++/115585] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-06-25

[Bug libstdc++/115585] [12/13/14/15 Regression] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|--disable-libstdcxx-verbose |[12/13/14/15 Regression]
                   |causes undefined symbol:    |--disable-libstdcxx-verbose
                   |_ZSt21__glibcxx_assert_fail |causes undefined symbol:
                   |PKciS0_S0_, version         |_ZSt21__glibcxx_assert_fail
                   |GLIBCXX_3.4.30              |PKciS0_S0_, version
                   |                            |GLIBCXX_3.4.30
   Target Milestone|---                         |12.5
      Known to work|                            |11.4.0
      Known to fail|                            |12.1.0
           Keywords|                            |ABI

[Bug libstdc++/115585] [12/13/14/15 Regression] --disable-libstdcxx-verbose causes undefined symbol: _ZSt21__glibcxx_assert_failPKciS0_S0_, version GLIBCXX_3.4.30

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115585

--- Comment #12 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:52370c839edd04df86d3ff2b71fcdca0c7376a7f

commit r15-1716-g52370c839edd04df86d3ff2b71fcdca0c7376a7f
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Jun 28 15:14:15 2024 +0100

    libstdc++: Define __glibcxx_assert_fail for non-verbose build [PR115585]

    When the library is configured with --disable-libstdcxx-verbose the
    assertions just abort instead of calling __glibcxx_assert_fail, and so I
    didn't export that function for the non-verbose build. However, that
    option is documented to not change the library ABI, so we still need to
    export the symbol from the library. It could be needed by programs
    compiled against the headers from a verbose build.

    The non-verbose definition can just call abort so that it doesn't pull
    in I/O symbols, which are unwanted in a non-verbose build.

    libstdc++-v3/ChangeLog:

            PR libstdc++/115585
            * src/c++11/assert_fail.cc (__glibcxx_assert_fail): Add
            definition for non-verbose builds.