public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tnfchris at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/115597] [15 Regression] vectorizer takes 20+ h compiling 510.parest in SPECCPU2017 since g:46bb4ce4d30ab749d40f6f4cef6f1fb7c7813452
Date: Sun, 23 Jun 2024 10:29:16 +0000	[thread overview]
Message-ID: <bug-115597-4-shiPvI7n1A@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-115597-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115597

--- Comment #3 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
> 
> Can you check whether that fixes the issue?
> 
> diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc
> index 9465d94de1a..212d5f97f7d 100644
> --- a/gcc/tree-vect-slp.cc
> +++ b/gcc/tree-vect-slp.cc
> @@ -6085,7 +6085,6 @@ static void
>  vect_cse_slp_nodes (scalar_stmts_to_slp_tree_map_t *bst_map, slp_tree& node)
>  {
>    if (SLP_TREE_DEF_TYPE (node) == vect_internal_def
> -      && SLP_TREE_CODE (node) != VEC_PERM_EXPR
>        /* Besides some VEC_PERM_EXPR, two-operator nodes also
>          lack scalar stmts and thus CSE doesn't work via bst_map.  Ideally
>          we'd have sth that works for all internal and external nodes.  */

Yeah that seems to do it, can compile SPECFP again.

  parent reply	other threads:[~2024-06-23 10:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-23  8:24 [Bug middle-end/115597] New: " tnfchris at gcc dot gnu.org
2024-06-23  8:49 ` [Bug middle-end/115597] " rguenth at gcc dot gnu.org
2024-06-23  9:29 ` rguenth at gcc dot gnu.org
2024-06-23 10:29 ` tnfchris at gcc dot gnu.org [this message]
2024-06-23 11:00 ` tnfchris at gcc dot gnu.org
2024-06-23 12:18 ` cvs-commit at gcc dot gnu.org
2024-06-23 12:19 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-115597-4-shiPvI7n1A@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).