[Bug target/115661] [15 Regression] wrong code at -O{2,3} on x86_64-linux-gnu since r15-1599-g63512c72df09b4

["cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115661

--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Christophe Lyon <clyon@gcc.gnu.org>:

https://gcc.gnu.org/g:c4b7b62bfa10816c1e08f0f9597d857f11379688

commit r15-1708-gc4b7b62bfa10816c1e08f0f9597d857f11379688
Author: Evgeny Karpov <Evgeny.Karpov@microsoft.com>
Date:   Fri Jun 28 12:37:12 2024 +0000

    i386: Fix regression after refactoring legitimize_pe_coff_symbol,
ix86_GOT_alias_set and PE_COFF_LEGITIMIZE_EXTERN_DECL [PR115635]

    This patch fixes 3 bugs reported after merging the "Add DLL
    import/export implementation to AArch64" series.
    https://gcc.gnu.org/pipermail/gcc-patches/2024-June/653955.html The
    series refactors the i386 codebase to reuse it in AArch64, which
    triggers some bugs.

    Bug 115661 - [15 Regression] wrong code at -O{2,3} on x86_64-linux-gnu
    since r15-1599-g63512c72df09b4
    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115661

    Bug 115635 - [15 regression] Bootstrap fails with failed self-test
    with the rust fe (diagnostic-path.cc:1153: test_empty_path: FAIL:
    ASSERT_FALSE ((path.interprocedural_p ()))) since
    r15-1599-g63512c72df09b4
    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115635

    Issue 1. In some code, i386 has been relying on the
    legitimize_pe_coff_symbol call on all platforms and should return
    NULL_RTX if it is not supported.

    Fix: NULL_RTX handling has been added when the target does not support
    PECOFF.

    Issue 2. ix86_GOT_alias_set is used on all platforms and cannot be
    extracted to mingw.

    Fix: ix86_GOT_alias_set has been returned as it was and is used on all
    platforms for i386.

    Bug 115643 - [15 regression] aarch64-w64-mingw32 support today breaks
    x86_64-w64-mingw32 build cannot represent relocation type BFD_RELOC_64
    since r15-1602-ged20feebd9ea31
    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115643

    Issue 3. PE_COFF_EXTERN_DECL_SHOULD_BE_LEGITIMIZED has been added and
    used with a negative operator for a complex expression without braces.

    Fix: Braces has been added, and
    PE_COFF_EXTERN_DECL_SHOULD_BE_LEGITIMIZED has been renamed to
    PE_COFF_LEGITIMIZE_EXTERN_DECL.

    2024-06-28  Evgeny Karpov <Evgeny.Karpov@microsoft.com>

            gcc/ChangeLog:
            PR bootstrap/115635
            PR target/115643
            PR target/115661
            * config/aarch64/cygming.h
            (PE_COFF_EXTERN_DECL_SHOULD_BE_LEGITIMIZED): Rename to
            PE_COFF_LEGITIMIZE_EXTERN_DECL.
            (PE_COFF_LEGITIMIZE_EXTERN_DECL): Likewise.
            * config/i386/cygming.h (GOT_ALIAS_SET): Remove the diffinition to
            reuse it from i386.h.
            (PE_COFF_EXTERN_DECL_SHOULD_BE_LEGITIMIZED): Rename to
            PE_COFF_LEGITIMIZE_EXTERN_DECL.
            (PE_COFF_LEGITIMIZE_EXTERN_DECL): Likewise.
            * config/i386/i386-expand.cc (ix86_expand_move): Return
            ix86_GOT_alias_set.
            * config/i386/i386-expand.h (ix86_GOT_alias_set): Likewise.
            * config/i386/i386.cc (ix86_GOT_alias_set): Likewise.
            * config/i386/i386.h (GOT_ALIAS_SET): Likewise.
            * config/mingw/winnt-dll.cc (get_dllimport_decl): Use
            GOT_ALIAS_SET.
            (legitimize_pe_coff_symbol): Rename to
            PE_COFF_LEGITIMIZE_EXTERN_DECL.
            * config/mingw/winnt-dll.h (ix86_GOT_alias_set): Declare
            ix86_GOT_alias_set.