From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 6BB963838A2A; Thu, 27 Jun 2024 08:48:55 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6BB963838A2A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1719478135;
	bh=douzz8iueGQoH62luhhQC0lwEDRSgLSEGT79MYZcgpo=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=V/WH0eZtP68QUJBYUedt7kupQusAtoxjPkh4mg2eAXnEenVsfN4RA3mXLc5UGLSUl
	 ZZPrme4xcX+UU4mZMHQldvQxlH3zWQqB9JmViKN6oth+TwCq9jo/5BT2CNgGGol1Uk
	 DJzuF0NMIsfgJ62ZQPo7PYujDHHKbiDesaR36GGQ=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/115668] Cannot format chrono::duration<unsigned>
Date: Thu, 27 Jun 2024 08:48:54 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 13.3.1
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: redi at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-115668-4-0Xu7YN0Sjs@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-115668-4@http.gcc.gnu.org/bugzilla/>
References: <bug-115668-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D115668

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:dafa750c8a6f0a088677871bfaad054881737ab1

commit r15-1690-gdafa750c8a6f0a088677871bfaad054881737ab1
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Jun 26 20:22:54 2024 +0100

    libstdc++: Fix std::format for chrono::duration with unsigned rep
[PR115668]

    Using std::chrono::abs is only valid if numeric_limits<rep>::is_signed
    is true, so using it unconditionally made it ill-formed to format a
    duration with an unsigned rep.

    The duration formatter might as negate the duration itself instead of
    using chrono::abs, because it already needs to check for a negative
    value.

    libstdc++-v3/ChangeLog:

            PR libstdc++/115668
            * include/bits/chrono_io.h (formatter<duration<R,P, C>::format):
            Do not use chrono::abs.
            * testsuite/20_util/duration/io.cc: Check formatting a duration
            with unsigned rep.=