public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/115673] [15 regression] gcc.target/i386/force-indirect-call-2.c test failure
Date: Sun, 30 Jun 2024 09:53:01 +0000	[thread overview]
Message-ID: <bug-115673-4-V9tBIRb5WI@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-115673-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115673

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|rguenth at gcc dot gnu.org         |

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
So it likely expects f1@GOTPCREL(%rip) to be CSEd?

f2:
.LFB2:
        .cfi_startproc
        subq    $8, %rsp
        .cfi_def_cfa_offset 16
        call    *f1@GOTPCREL(%rip)
        leaq    f3(%rip), %rax
        call    *%rax
        addq    $8, %rsp
        .cfi_def_cfa_offset 8
        jmp     *f1@GOTPCREL(%rip)

indeed with GCC 14 we get

f2:
.LFB2:
        .cfi_startproc
        pushq   %rbx
        .cfi_def_cfa_offset 16
        .cfi_offset 3, -16
        movq    f1@GOTPCREL(%rip), %rbx
        call    *%rbx
        leaq    f3(%rip), %rax
        call    *%rax
        movq    %rbx, %rax
        popq    %rbx
        .cfi_def_cfa_offset 8
        jmp     *%rax

I think both are perfectly OK for what the testcase should expect, so it's
a testism.  But I think it's also a missed optimization now.

  parent reply	other threads:[~2024-06-30  9:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27  4:48 [Bug target/115673] New: " sjames at gcc dot gnu.org
2024-06-27  4:50 ` [Bug target/115673] " sjames at gcc dot gnu.org
2024-06-27  4:50 ` [Bug rtl-optimization/115673] " pinskia at gcc dot gnu.org
2024-06-27  5:59 ` [Bug target/115673] " rguenth at gcc dot gnu.org
2024-06-27  6:02 ` sjames at gcc dot gnu.org
2024-06-28 15:23 ` sjames at gcc dot gnu.org
2024-06-30  9:53 ` rguenth at gcc dot gnu.org [this message]
2024-06-30 16:42 ` ubizjak at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-115673-4-V9tBIRb5WI@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).