public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/115936] [15 Regression] GCN vs. ivopts: replace constant_multiple_of with aff_combination_constant_multiple_p [PR114932]
Date: Wed, 17 Jul 2024 15:22:43 +0000	[thread overview]
Message-ID: <bug-115936-4-QeJIEzIzH3@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-115936-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115936

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:

https://gcc.gnu.org/g:0135a90de5a99b51001b6152d8b548151ebfa1c3

commit r15-2099-g0135a90de5a99b51001b6152d8b548151ebfa1c3
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Wed Jul 17 16:22:14 2024 +0100

    middle-end: fix 0 offset creation and folding [PR115936]

    As shown in PR115936 SCEV and IVOPTS create an invalidate IV when the IV is
    a pointer type:

    ivtmp.39_65 = ivtmp.39_59 + 0B;

    where the IVs are DI mode and the offset is a pointer.
    This comes from this weird candidate:

    Candidate 8:
      Var befor: ivtmp.39_59
      Var after: ivtmp.39_65
      Incr POS: before exit test
      IV struct:
        Type:       sizetype
        Base:       0
        Step:       0B
        Biv:        N
        Overflowness wrto loop niter:       No-overflow

    This IV was always created just ended up not being used.

    This is created by SCEV.

    simple_iv_with_niters in the case where no CHREC is found creates an IV
with
    base == ev, offset == 0;

    however in this case EV is a POINTER_PLUS_EXPR and so the type is a
pointer.
    it ends up creating an unusable expression.

    gcc/ChangeLog:

            PR tree-optimization/115936
            * tree-scalar-evolution.cc (simple_iv_with_niters): Use sizetype
for
            pointers.

  parent reply	other threads:[~2024-07-17 15:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-15 10:50 [Bug target/115936] New: " tschwinge at gcc dot gnu.org
2024-07-15 11:23 ` [Bug target/115936] " tnfchris at gcc dot gnu.org
2024-07-15 12:33 ` tnfchris at gcc dot gnu.org
2024-07-15 13:35 ` rguenth at gcc dot gnu.org
2024-07-15 13:40 ` tnfchris at gcc dot gnu.org
2024-07-15 16:17 ` tnfchris at gcc dot gnu.org
2024-07-15 16:17 ` tnfchris at gcc dot gnu.org
2024-07-17 15:22 ` cvs-commit at gcc dot gnu.org [this message]
2024-07-17 15:27 ` [Bug tree-optimization/115936] " tnfchris at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-115936-4-QeJIEzIzH3@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).